Skip to content

fix(ci): the invisible-character gate never matched anything#86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hyperpolymath merged 2 commits into from
Aug 28, 2026
Merged

fix(ci): the invisible-character gate never matched anything #86

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ce1f9d
fix(ci): the invisible-character gate never matched anything
hyperpolymath Aug 27, 2026
fb1a222
fix(ci): make invisible-character PCRE locale-independent
hyperpolymath Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/dogfood-gate.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -120,7 +120,7 @@ jobs:
# Checks for: zero-width spaces, zero-width joiners, BOM, soft hyphens,
# non-breaking spaces, null bytes, and other invisible Unicode in source files.
set +e
PATTERNS='\xc2\xa0|\xe2\x80\x8b|\xe2\x80\x8c|\xe2\x80\x8d|\xef\xbb\xbf|\xc2\xad|\xe2\x80\x8e|\xe2\x80\x8f|\xe2\x80\xaa|\xe2\x80\xab|\xe2\x80\xac|\xe2\x80\xad|\xe2\x80\xae|\x00'
PATTERNS='(*UTF)[\x00-\x08\x0B\x0C\x0E-\x1F\x{a0}\x{ad}\x{200b}-\x{200f}\x{202a}-\x{202f}\x{2060}\x{2066}-\x{2069}\x{feff}]'
find "$GITHUB_WORKSPACE" \
-not -path '*/.git/*' -not -path '*/node_modules/*' \
-not -path '*/.deno/*' -not -path '*/target/*' \
Expand All@@ -131,7 +131,7 @@ jobs:
-o -name '*.yml' -o -name '*.yaml' -o -name '*.md' -o -name '*.adoc' \
-o -name '*.idr' -o -name '*.zig' -o -name '*.v' -o -name '*.jl' \
-o -name '*.gleam' -o -name '*.hs' -o -name '*.ml' -o -name '*.sh' \) \
-exec grep -Prl "$PATTERNS" {} \; > /tmp/empty-lint-results.txt 2>/dev/null
-exec grep -aPrl "$PATTERNS" {} \; > /tmp/empty-lint-results.txt 2>/dev/null

@codacy-productioncodacy-productionBotAug 27, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 MEDIUM RISK

Suggestion: The current implementation has several logic and performance issues that should be addressed:

  1. Redundancy: The -r flag in grep is unnecessary when find is already passing individual file paths.
  2. Performance: Switching from \; to + will significantly improve performance by batching files into fewer process invocations.
  3. Unreliable Exit Code: The EL_EXIT logic is flawed because grep returns 1 when no matches are found, causing find to potentially report failure on 'clean' files.
  4. Gate Failure: To function as a gate, the script must explicitly exit 1 when $FINDINGS is greater than 0.
Suggested change
-exec grep -aPrl "$PATTERNS" {} \; > /tmp/empty-lint-results.txt 2>/dev/null
-exec grep -aPl "$PATTERNS" {} + > /tmp/empty-lint-results.txt 2>/dev/null
FINDINGS=$(wc -l < /tmp/empty-lint-results.txt)
if [ "$FINDINGS" -gt 0 ]; then
cat /tmp/empty-lint-results.txt
exit 1
fi

EL_EXIT=$?
set -e

Expand Down
Loading