Skip to content

fix(governance): name a co-owner so require_code_owner_review can pass - #599

Merged
hyperpolymath merged 1 commit into
mainfrom
chore/codeowners-co-owner
Aug 7, 2026
Merged

fix(governance): name a co-owner so require_code_owner_review can pass#599
hyperpolymath merged 1 commit into
mainfrom
chore/codeowners-co-owner

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

The deadlock

.github/CODEOWNERS made @hyperpolymath the sole owner of every path, and the Base ruleset sets require_code_owner_review: true.

GitHub will not let a pull request's author satisfy the code-owner requirement themselves. With one owner who is also always the author, the rule could not be satisfied by anybody — every maintainer-authored PR sat permanently BLOCKED.

The evidence is in the merge history: #592, #593 and #597 all merged with DISMISSED / CHANGES_REQUESTED and zero approving reviews, via the admin bypass (RepositoryRole id=2, mode=always).

A rule that can never pass doesn't gate anything. It just makes bypass the normal path — and once bypass is routine it stops carrying information, which is how three other broken rules in this same ruleset went unnoticed for months.

The fix

@JoshuaJewell (repo admin, the only other org member) is named co-owner, so either maintainer can approve the other's work and the requirement becomes satisfiable for the first time.

On every line, not just *. In CODEOWNERS the last matching rule wins, and a specific path line replaces the default rather than adding to it. Co-owning only the * default would leave SECURITY.md, .github/workflows/, .machine_readable/, LICENSE, *.sh and the rest single-owned — and any PR touching them still deadlocked.

Bootstrapping

The ruleset reads CODEOWNERS from the base branch, so this change only takes effect once it is on main. This PR itself therefore still needs one admin-bypass merge. After that, code-owner review works normally.

Context

This is the fourth of four independent deadlocks found in this ruleset on 2026-08-07:

  1. code_quality / code_coverage / copilot_code_review — features producing no PR result — removed
  2. required_deployments: github-pages — Pages deploys on push only, so no PR head can ever have one — removed (18 other repos still affected; see scripts/clear-pages-deployment-deadlock.sh)
  3. code_scanning @ error threshold — 13 alerts from May–July, all already excused in .hypatia-baseline.jsonresolved, 12 dismissed
  4. require_code_owner_reviewthis PR

🤖 Generated with Claude Code

GitHub will not let a PR author satisfy the code-owner requirement themselves. With @hyperpolymath as SOLE owner of every path, the Base ruleset's require_code_owner_review could not be satisfied by anybody: every maintainer-authored PR sat permanently BLOCKED and only the admin bypass moved anything. #592, #593 and #597 all merged with DISMISSED/CHANGES_REQUESTED and zero approvals.
@JoshuaJewell (repo admin, the only other org member) is named co-owner on EVERY line, not just the * default: in CODEOWNERS the last matching rule wins and a specific path line REPLACES the default, so co-owning only * would leave SECURITY.md, .github/workflows/, *.sh and the rest single-owned and still deadlocked.
@hyperpolymath
hyperpolymath merged commit 821ada2 into mainAug 7, 2026
33 of 34 checks passed
@hyperpolymath
hyperpolymath deleted the chore/codeowners-co-owner branch August 7, 2026 14:25
@gitar-bot

gitar-botBot commented Aug 7, 2026

Copy link
Copy Markdown

Note

Automatic reviews are paused because your trial's included automatic processing has been used for this period. Upgrade now, or comment "Gitar review" to run a review anytime.
Learn more

Code Review✅ Approved

Adds a co-owner to the CODEOWNERS configuration to resolve the maintainer review deadlock caused by single-owner path rules. No issues found.

Auto-approved and auto-merge armed: No blocking issues found.
Please see Auto-approve Docs for details on setting custom approval criteria. — merges when pipeline and required approvals pass.

Options

Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose 

Important

Your trial ends in 3 days — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more.

Was this helpful? React with 👍 / 👎 | Gitar

@sonarqubecloud

Copy link
Copy Markdown

hyperpolymath added a commit that referenced this pull request Aug 7, 2026
Brings in the CODEOWNERS co-owner fix (#599). REGISTRY.a2ml is GENERATED — if it conflicted it was regenerated with 'just registry', never hand-merged.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@hyperpolymath