Skip to content

Add abstract client tests - #246

Merged
pavolloffay merged 7 commits into
mainfrom
ENG-7540/abstractHttpClientTest
Feb 3, 2021
Merged

Add abstract client tests#246
pavolloffay merged 7 commits into
mainfrom
ENG-7540/abstractHttpClientTest

Conversation

@shashank11p

@shashank11pshashank11p commented Jan 29, 2021•
edited by pavolloffay
Loading

Copy link
Copy Markdown
Contributor

Updates #98

pavolloffay
pavolloffay reviewed Feb 1, 2021
View reviewed changes

@pavolloffaypavolloffay left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress 👍

Comment threadtesting-common/src/main/java/org/hypertrace/agent/testing/AbstractHttpClientTest.java Outdated
Comment threadtesting-common/src/main/java/org/hypertrace/agent/testing/AbstractHttpClientTest.java Outdated
Comment threadtesting-common/src/main/java/org/hypertrace/agent/testing/AbstractHttpClientTest.java Outdated
Comment threadtesting-common/src/main/java/org/hypertrace/agent/testing/AbstractHttpClientTest.java
Comment threadtesting-common/src/main/java/org/hypertrace/agent/testing/AbstractHttpClientTest.java Outdated
Comment threadtesting-common/src/main/java/org/hypertrace/agent/testing/AbstractHttpClientTest.java Outdated
Comment threadtesting-common/src/main/java/org/hypertrace/agent/testing/AbstractHttpClientTest.java Outdated
pavolloffay
pavolloffay reviewed Feb 2, 2021
View reviewed changes
Comment thread...rumentation/hypertrace/apachehttpasyncclient/ApacheAsyncClientInstrumentationModuleTest.java Outdated
Comment thread...rumentation/hypertrace/apachehttpasyncclient/ApacheAsyncClientInstrumentationModuleTest.java Outdated
Comment thread...rumentation/hypertrace/apachehttpasyncclient/ApacheAsyncClientInstrumentationModuleTest.java Outdated
Comment threadtesting-common/src/main/java/org/hypertrace/agent/testing/AbstractHttpClientTest.java Outdated
Comment threadtesting-common/src/main/java/org/hypertrace/agent/testing/AbstractHttpClientTest.java
Comment threadtesting-common/src/main/java/org/hypertrace/agent/testing/AbstractHttpClientTest.java Outdated
Comment threadtesting-common/src/main/java/org/hypertrace/agent/testing/AbstractHttpClientTest.java Outdated
Comment threadtesting-common/src/main/java/org/hypertrace/agent/testing/AbstractHttpClientTest.java Outdated
Comment threadtesting-common/src/main/java/org/hypertrace/agent/testing/AbstractHttpClientTest.java Outdated
Comment threadtesting-common/src/main/java/org/hypertrace/agent/testing/AbstractHttpClientTest.java Outdated
@pavolloffaypavolloffay changed the title Adding AbstractHttpClientTest class for Http client testsAdd abstract client testsFeb 2, 2021
pavolloffay
pavolloffay reviewed Feb 2, 2021
View reviewed changes
Comment thread...rumentation/hypertrace/apachehttpasyncclient/ApacheAsyncClientInstrumentationModuleTest.java Outdated
Comment thread...rumentation/hypertrace/apachehttpasyncclient/ApacheAsyncClientInstrumentationModuleTest.java Outdated
Comment thread...rumentation/hypertrace/apachehttpasyncclient/ApacheAsyncClientInstrumentationModuleTest.java Outdated
Comment threadtesting-common/src/main/java/org/hypertrace/agent/testing/AbstractHttpClientTest.java Outdated
@shashank11p
shashank11p marked this pull request as ready for review February 2, 2021 12:39
pavolloffay
pavolloffay reviewed Feb 2, 2021
View reviewed changes
Comment thread...nt/instrumentation/hypertrace/apachehttpclient/v4_0/ApacheHttpClientInstrumentationTest.java Outdated
Comment threadtesting-common/src/main/java/org/hypertrace/agent/testing/AbstractHttpClientTest.java
Comment threadtesting-common/src/main/java/org/hypertrace/agent/testing/AbstractHttpClientTest.java Outdated
Comment threadtesting-common/src/main/java/org/hypertrace/agent/testing/AbstractHttpClientTest.java Outdated
Comment threadtesting-common/src/main/java/org/hypertrace/agent/testing/AbstractHttpClientTest.java
Comment threadtesting-common/src/main/java/org/hypertrace/agent/testing/AbstractHttpClientTest.java Outdated
@pavolloffay
pavolloffay merged commit 8275b70 into mainFeb 3, 2021
@pavolloffay
pavolloffay deleted the ENG-7540/abstractHttpClientTest branch February 3, 2021 09:14
shashank11p added a commit to shashank11p/javaagent that referenced this pull request Feb 3, 2021
@shashank11p
Merge pull request#2from hypertrace/main
9aa407a
Add abstract client tests (hypertrace#246)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pavolloffaypavolloffaypavolloffay approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shashank11p@pavolloffay