Skip to content

bug: caller-utils import not generated in /tests #331

Description

@Gohlub

Describe the bug
Since tests depend on caller-utils, we should automatically import them in tests/ Cargo.toml file. The current behavior is in my opinion not ideal: kit run-tests builds the caller utils before building the tests (which is good), but I had to prepopulate the templates with import caller-utils = '../target/caller/utils in the testing package Cargo.toml for it to work out-of-the-box (which I think might cause issues if someone tried to do just kit b of the testing package).

To Reproduce
Create the new hyperapp-echo template and delete the caller-utils import, then run kit-tests and it should spit out a bunch of errors (since a lot of imports from the main package go through caller utils).

Expected behavior
Whenever caller utils are built, we should make kit copy that import into /test Cargo.toml (similar to how these updates are done for the main package).

Additional context
I think this we should maybe rethink this flow to be more compact and with less loose ends. An easy fix would be to just import them whenever we do 'kit run-tests' (which builds the main package with caller-utils anyways), but it seems to me that caller-utils is part of the types-{app_name}-template-dot-os-v0 WIT world, which includes 'import {package_name}; andimport lib;`, but I am not sure whether this somehow leads to better behavior. Let me know what you think.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions