Auto-pilot: honour the base-branch marker when opening the pull request - #95
Merged
Merged
Conversation
The issue bridge and the belt dispatcher both resolve a pull request base from the issue's `<!-- base-branch: X -->` marker. Auto-pilot did not: it took `repoInfo.default_branch` at both of its PR sites and never read the marker at all. Auto-pilot is the component that actually calls pulls.create, so the marker was honoured when the branch was cut and then ignored when the PR was opened. An issue marked `eval/cursor` produced branch `cursor/issue-285` and a pull request into `main` — the per-lane separation collapsed silently, and merging any such PR would put one lane's work on the shared branch. Both sites now resolve marker over default, verify the branch exists before using it, fall back with a warning when it does not, and log the chosen base and its source. This is the third and last place that computed a PR base: the bridge, the belt dispatcher and auto-pilot are now consistent, and no `const baseBranch = repoInfo.default_branch` remains in any of them. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FC8XoyssN5v6hQCTtcjoB5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue bridge and the belt dispatcher both resolve a pull request base from the issue's
<!-- base-branch: X -->marker. Auto-pilot did not: it tookrepoInfo.default_branchat both of its PR sites and never read the marker at all.Auto-pilot is the component that actually calls pulls.create, so the marker was honoured when the branch was cut and then ignored when the PR was opened. An issue marked
eval/cursorproduced branchcursor/issue-285and a pull request intomain— the per-lane separation collapsed silently, and merging any such PR would put one lane's work on the shared branch.Both sites now resolve marker over default, verify the branch exists before using it, fall back with a warning when it does not, and log the chosen base and its source. This is the third and last place that computed a PR base: the bridge, the belt dispatcher and auto-pilot are now consistent, and no
const baseBranch = repoInfo.default_branchremains in any of them.Claude-Session: https://claude.ai/code/session_01FC8XoyssN5v6hQCTtcjoB5
Workflow Source
Started from:
Automation intent:
Notes:
Summary
Testing