Skip to content

fix(zip): use ushort for ITaggedData.TagID - #669

Merged
piksel merged 1 commit into
icsharpcode:masterfrom
Numpsy:rw/zip/ushort_tag
Oct 9, 2021
Merged

fix(zip): use ushort for ITaggedData.TagID#669
piksel merged 1 commit into
icsharpcode:masterfrom
Numpsy:rw/zip/ushort_tag

Conversation

@Numpsy

@NumpsyNumpsy commented Oct 7, 2021

Copy link
Copy Markdown
Contributor

This is the TagId change from #470 split into a stand alone change.

I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.

@codecov

codecovBot commented Oct 7, 2021

Copy link
Copy Markdown

Codecov Report

Merging #669 (730f50f) into master (b5b1a92) will increase coverage by 0.24%.
The diff coverage is 0.00%.

Impacted file tree graph

@@ Coverage Diff @@## master #669 +/- ##
==========================================
+ Coverage 73.07% 73.31% +0.24% 
==========================================
Files 68 68 Lines 8305 8305 ==========================================
+ Hits 6069 6089 +20 + Misses 2236 2216 -20 
Impacted FilesCoverage Δ
src/ICSharpCode.SharpZipLib/Zip/ZipExtraData.cs76.33% <0.00%> (ø)
...ode.SharpZipLib/Zip/Compression/DeflaterHuffman.cs97.87% <0.00%> (+6.07%)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5b1a92...730f50f. Read the comment docs.

@pikselpiksel self-assigned this Oct 8, 2021
@pikselpiksel changed the title Change ITaggedData.TagID from a short to a ushortfix(zip): use ushort for ITaggedData.TagIDOct 9, 2021
@piksel
piksel merged commit d34e5c9 into icsharpcode:masterOct 9, 2021
@Numpsy
Numpsy deleted the rw/zip/ushort_tag branch October 9, 2021 17:00
@pikselpiksel linked an issue Oct 9, 2021 that may be closed by this pull request
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extra IDs larger than short.MaxValue not supported in ZipExtraData

2 participants

@Numpsy@piksel