Uh oh!
There was an error while loading. Please reload this page.
ENH: write and read native coordinates in VTK - #292
Conversation
79f2285 to
d6960c9Compareneutrinoceros
commented
Nov 5, 2024
I rewrote the branch history to help bisect the current issue: vtk outputs are corrupted and unreadable. The breaking commit is eaa2322 (as one might expect). I also changed back the reading logic so that
|
neutrinoceros
commented
Nov 5, 2024
I think a fundamental issue with our current approach is that we're writing arbitrary fields in the style of the VTK header but outside said header. We need to either:
I think option 2) is preferable but I don't know if it's allowed. |
Uh oh!
There was an error while loading. Please reload this page.
neutrinoceros
commented
Nov 6, 2024
found a problem downstream: https://github.com/volodia99/nonos/pull/371#issuecomment-2459596390 |
neutrinoceros
commented
Nov 6, 2024
all clear, the issue was downstream |
Co-authored-by: volodia99 <gaylor.wafflard@univ-grenoble-alpes.fr>
0661cea to
1087e85CompareCo-authored-by: Clément Robert <cr52@protonmail.com>
glesur
commented
Nov 15, 2024
Thanks for this improvement, that seems to fix the issue of reconstructing the cell coordinates from the VTK cartesian coordinates. However, I think there is a regression: the original version of This new implementation misses that last rightmost face ( |
glesur
commented
Nov 26, 2024
Actually, my previous comment was incorrect, it does include the last rightmost face. So we're good to go. |
ENH: write and read native coordinates in VTK (#292)
glesur
commented
Nov 26, 2024
Manually merged as github wouldn't let me do it from their website. |
No description provided.