Uh oh!
There was an error while loading. Please reload this page.
Implement Collisionless heat flux into the Braginskii module - #317
Merged
Conversation
…lay which slope limiter is used, fixed typo in the braginskii doc
updated ShowConfig functions from braginskii tc and viscosity to disp…
glesur
self-requested a review
January 21, 2025 16:18
vreville
commented
Jan 21, 2025
ContributorAuthor
Hum, it looks like the non regression tests from the FargoMHDspherical is trying to compare 16x16x128 cubes with 16x16x64 cubes. I did not touch this file, is this expected ? |
glesur
reviewed
Jan 21, 2025
Uh oh!
There was an error while loading. Please reload this page.
glesur
reviewed
Jan 22, 2025
glesur
left a comment
Contributor
There was a problem hiding this comment.
Ok, except for the userdef function signature which would benefit from using a single std::vector<IdefixArray3D> as parameter for all of the implementations.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
glesur
reviewed
Feb 9, 2025
Uh oh!
There was an error while loading. Please reload this page.
glesur
reviewed
Feb 9, 2025
glesur
left a comment
Contributor
There was a problem hiding this comment.
All good, just change std::vector[] by std::vector.at() and we're good to go
Merged
glesur added a commit
that referenced
this pull request
Apr 16, 2025
## [2.2.01] 2025-04-16 ### Changed - Fix a bug that led to instabilities in the RKL scheme with very small grid spacings (#323) - Fix a bug that prevented Idefix from running with Sycl backend (required on Intel GPUs) (#331) - Fix an error that led to incorrect electrical current regularisation around the polar axis in non-Ideal MHD (#333) - Improve div(B) checks with a dimensionless implementation, avoiding too large divB errors in grids with large stretch factors (#334) ### Added - Time-Implicit drag for multiple dust species, preventing small time steps for strongly coupled dust grains (#321) - Collisionless heat flux added to the Braginskii module (#317) - New global `idfx::DumpArray` debugging function to dump any Idefix array into a numpy array that can read from python (#318) - Automatic benchmark plots in the documentation (#319) - More CI tests of grid coarsening (#329) - Dump outputs based on wallclock time (#335) --------- Co-authored-by: Victor Réville <victorreville@gmail.com> Co-authored-by: Hal Bal <vreville@irap.omp.eu> Co-authored-by: Jean Kempf <jean.kempf@irap.omp.eu> Co-authored-by: Victor Réville <47865059+vreville@users.noreply.github.com> Co-authored-by: Marc Coiffier <marc.coiffier@univ-grenoble-alpes.fr> Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an option to the
bragTDiffusionmodule. A new keyword is set to eithernosatorwcless. With the latter, the heat flux is a combination of the Braginskii heat flux and a collisionless heat flux \propto p v (where p is the thermal fluid pressure and v the bulk velocity). The transition from the Braginskii to the collisionless form is handled through a third parameter alpha (typically an array that depends on the coordinates or the density) while the amplitude of the collisionless heat flux is controlled by a fourth parameter beta, usually constant but can be userdef.A test and 1D example is given in test/MHD/clessTDiffusion/.
bragTDiffusion tests have been updated to include the new option.