Skip to content

Reorganise tests - #367

Merged
glesur merged 22 commits into
developfrom
reorganiseTests
Mar 26, 2026
Merged

Reorganise tests#367
glesur merged 22 commits into
developfrom
reorganiseTests

Conversation

@glesur

Copy link
Copy Markdown
Contributor
  • separate tests of specific IO routines from physics tests (XDMF and restart dumps)
  • add all IO tests to github actions
  • add Sedov to the test suite.

svalat added a commit to svalat/idefix that referenced this pull request Mar 23, 2026
…way via testme.json + handle single variant defined in testme.json
@glesur
glesur requested a review from CopilotMarch 24, 2026 07:39

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Reorganizes the test suite by separating IO-focused tests (restart dumps, XDMF, Pydefix) from physics tests, and updates CI to run the expanded test matrix (including Sedov).

Changes:

  • Moved restart validation out of the OrszagTang3D physics test into a dedicated IO “dump” test.
  • Added new IO tests for XDMF output and Pydefix, and wired them into GitHub Actions.
  • Added Sedov blast wave to CI and adjusted some test tolerances/output cadence.

Reviewed changes

Copilot reviewed 23 out of 24 changed files in this pull request and generated 5 comments.

Show a summary per file
FileDescription
test/MHD/OrszagTang3D/testme.pyRemoves restart validation from the physics regression test.
test/MHD/OrszagTang3D/setup.cppRemoves restart-analysis logic from OrszagTang3D setup.
test/MHD/LinearWaveTest/testme.pyAdjusts tolerance for the linear wave test.
test/MHD/LinearWaveTest/idefix-entropy.iniIncreases log cadence for the entropy variant.
test/IO/xdmf/testme.pyAdds a new IO test driver intended to validate XDMF output.
test/IO/xdmf/setup.cppAdds minimal setup to generate a representative MHD state for XDMF dumps.
test/IO/xdmf/idefix.iniAdds a config that enables XDMF + dump output for the new test.
test/IO/xdmf/definitions.hppAdds build definitions for the new XDMF IO test.
test/IO/pydefix/testme.pyAdds a new IO test covering Pydefix dump generation/regression.
test/IO/pydefix/python_requirements.txtAdjusts pybind11 minimum version and adds a comment.
test/IO/pydefix/idefix.iniAdjusts output cadence and enables dmp output for Pydefix test.
test/IO/dump/testme.pyAdds a dedicated restart-dump IO test driver.
test/IO/dump/setup.cppAdds restart validation analysis (moved from OrszagTang3D).
test/IO/dump/definitions.hppAdds build definitions for the new dump IO test.
test/IO/dump/CMakeLists.txtEnables MHD property for the IO dump test target.
test/HD/SedovBlastWave/idefix.iniRemoves XDMF output from Sedov and tweaks output formatting.
test/HD/SedovBlastWave/CMakeLists.txtAdds an MHD property line (in addition to HDF5).
src/setup.cppSuppresses default Setup warning when built with Python enabled.
src/pydefix.cppMarks some arrays as maybe_unused and prints Python runtime details at startup.
src/output/xdmf.cppAdds maybe_unused annotations to avoid warnings in some build modes.
referenceUpdates submodule reference SHA.
CMakeLists.txtAdds stricter HDF5 parallel checks under MPI and adds Python3/pybind11 CMake path setup.
.github/workflows/idefix-ci-jobs.ymlAdds Sedov + IO test job and includes LinearWaveTest in CI.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threadtest/IO/xdmf/testme.py Outdated
Comment threadtest/IO/dump/testme.py
Comment threadCMakeLists.txt Outdated
Comment threadsrc/pydefix.cpp
Comment threadtest/IO/dump/setup.cpp Outdated
glesurand others added 3 commits March 24, 2026 13:56
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@glesur
glesur merged commit 8171c32 into developMar 26, 2026
41 checks passed
@glesur
glesur deleted the reorganiseTests branch March 26, 2026 07:58
@glesurglesur mentioned this pull request Apr 21, 2026
Merged
glesur added a commit that referenced this pull request Apr 22, 2026
### Changed
- fixed a bug that could lead to diverging results around the spherical axis in non-ideal MHD in 2.5D and 3D (#356)
- refactor of the MPI exchange routines and boundary routines to avoid buildup of roundoff errors at domain faces/edges that could lead to the sudden burst of div(B) or incoherences between MPI sub-domains (#357)
- fixed a bug that could lead to compilations error when targetting AMD APUs (#359)
- fixed a bug that led to the generation of incorrect subviews in 2.5D with vector_potential enabled (#362)
- fixed a bug that could lead to memory corruption when using the UCT_HLLD emf reconstruction scheme and DIMENSIONS < COMPONENTS (#363)
- reorganise the test to separate specific IO tests from physics tests (#367)
### Added
- magnetic vector potential is now accessible from pydefix when enabled (#361)
- use ccache in the test suite to reduce the runtime of continuous integration (#364)
- automatically detects pybind11 path with cmake when using pydefix (#367)
- skeleton to run the test suite with pytest (#366)
---------------------------------------------------------------------------
Co-authored-by: Clément Robert <cr52@protonmail.com>
Co-authored-by: Sébastien Valat <sebastien.valat.dev@orange.fr>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@glesur