Refactoring server.py and migrating to python-osc

[Itaborala]

This should solve #9 and #11

Changes:

• The Server class was refactored to use python-osc instead of pyliblo for OSC
• Handler structure was simplified
• The code should no longer require liblo, pyliblo and Cython .
• Version on setup.py was changed to 0.0.6, preparing for publishing

For approving this pull request, we need to make sure that the new server is fully backwards compatible with all other classes and methods and no bugs (originated by the refactoring) are present.

[ideoforms]

Just spotted this PR - thanks so much!
I haven't yet tested or run the code, so this first review is mostly cosmetics. I'll follow up with a second review that takes a closer look at performance, tests etc.

[spyridonpallis]

Thanks for updating this guys. Any timeline on when this will be completed?

[Itaborala]

Hi @spyridonpallis , I've been very busy this month working on a time sensitive project. I should get back to this next week and hopefully we can have it completed in May. :)

[Itaborala]

@ideoforms Just letting you know I'm back to this, fully willing to finishing and having this publishes this month, if possible

[ideoforms]

@Itaborala That would be great!
I have just cloned from your fork. Unit tests are passing except for test_server_get_version, which looks pretty simple to fix:

 def get_version(self):
self._send_msg("/version")
> return self._await_response("/version.reply", None, version_handler)
E NameError: name 'version_handler' is not defined
supercollider/server.py:114: NameError

Let me know when you're at a point when this is ready for review with passing tests, and I'll take a final look over.

[ideoforms]

@Itaborala Let me know if you're still intending on finishing this up. No worries if not; I'd be happy to merge the changes and then tidy themself up myself. Thanks!

[Itaborala]

Hi @ideoforms , sorry, those busy days became some busy months..
I can help you finish this up right now. I fixed the error, now all tests should work.

Are there any other changes/additions to be made?

[ideoforms]

Thanks for the PR! Just ran the tests and they're all passing fine. 🎉

I've added a few comments, main one being about restoring the previous approach to handling callback arguments - then good to merge.

[Itaborala]

@ideoforms I've addressed all requests. Tests are working for me too.

Additionally, I have noticed that in buffer.py and synth.py there were if blocking statements which were still using pyliblo handlers, although the condition blocking=False is never tested. I don't know of any usecases for blocking=False, but I have now addressed it.

To account for python-osc, I have changed server.add_handler() into server.dispatcher.map(), and included a method in server.py that can clear, or 'flush' all non_blocking handlers (remember that the _await_response method unmaps the handles after the timeout).
See 910e857 for this addition

[ideoforms]

Looks great @Itaborala! Merging now, thanks for all your work on this.

[ideoforms]

@Itaborala I have just added tests for the blocking=False situations. These are needed if you have a large number of simultaneous queries happening and don't want to hold up the foreground thread whilst awaiting responses.

On that note, I realised that part of the query system will now be broken following the move to python-osc. The callback system previously had callbacks indexed not only by the OSC address (/n_set) but also by the synth ID and the parameter being queried. This meant that several getter queries could be simultaneously deployed, and their callbacks would all be triggered when the responses were received. Now, callbacks are indexed only by the OSC address - meaning that each new /n_set callback registered will overwrite the previous ones. I realised there wasn't a test to catch this case which is how it slipped through, but I spotted it because match_args is now unused in _await_response().

I don't think it should hold up a new release as it's probably a feature that's only needed in a few cases, but I'll add an issue for it.

[ideoforms]

I've now published this to PyPi as release v0.0.6:
https://pypi.org/project/supercollider/