fix: normalize Cloudflare deploy config base path - #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What broke
Cloudflare Vite generates
apps/web/.wrangler/deploy/config.jsonaftervite build, while Dockmark's canonical user config lives at repository-rootwrangler.jsonc. Runningwrangler deployfrom the Web workspace made Wrangler see the two configs with different base paths and abort.Fix
wrangler.jsoncas the canonical input config so Deploy-to-Cloudflare can still see/provision D1scripts/prepare-cloudflare-deploy.mjsto promote Vite's generated deploy redirect to root.wrangler/deploy/config.jsonwhile preserving its generated output targetDBbinding rather than the database namewrangler deploy --dry-runto CI so generated-config deployment failures are caught before mergeExpected Cloudflare configuration
/npm run build:webnpm run deploy:builtmainThe existing root
npm run deployremains appropriate for Deploy-to-Cloudflare and local CLI use because it builds the Web workspace before running the same root deployment flow.