Uh oh!
There was an error while loading. Please reload this page.
fix: detached HEAD fallback, SSM doc version, upstream fixes doc - #6
Merged
Conversation
Documents the 4 issues preventing Bedrock instance-profile auth from working out of the box, with specific file paths, code fixes, and root cause analysis for upstream maintainers. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…pdate - REPO_BRANCH falls back to "main" when git returns "HEAD" (detached checkout from tags, CI, or shallow clones) - SSM update-document-default-version now uses the numeric version returned by update-document instead of '$LATEST' which is rejected Addresses PR #5 review feedback items 1 and 2. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Content checks: REPO_BRANCH detection, repo_branch in TF/CFN, SSM numeric version capture - Unit tests: HEAD→main fallback, normal branch preserved, version regex accepts/rejects correct values Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to PR #5, addressing review feedback and adding documentation.
REPO_BRANCHnow falls back tomainwhen git returnsHEAD(tag checkouts, CI, shallow clones)update-document-default-versionnow uses the numeric version fromupdate-documentresponse instead of$LATEST(which is rejected by the API)Test plan
bash deploy/test-templates.sh— 42/42 new+existing tests pass (1 pre-existing stale test)🤖 Generated with Claude Code