Conversation
inducerforce-pushed
the
zeros
branch
3 times, most recently
from
August 5, 2024 19:07
0db815a to
d8859c8Compareinducer
enabled auto-merge (rebase)
August 5, 2024 19:08
alexfikl
reviewed
Aug 5, 2024
Uh oh!
There was an error while loading. Please reload this page.
inducer
disabled auto-merge
August 5, 2024 19:25
inducer
commented
Aug 5, 2024
OwnerAuthor
Un-auto-merging here, to give you a chance/more time to voice an opinion... |
alexfikl
approved these changes
Aug 5, 2024
alexfikl
left a comment
Collaborator
There was a problem hiding this comment.
Took a quick look, but everything else looks ok! (with a small question)
Uh oh!
There was an error while loading. Please reload this page.
inducer
commented
Aug 5, 2024
OwnerAuthor
Thanks for taking a look! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm plotting to deprecate/remove
actx.zerosin #190. This prepares for that.