Towards grudge typing - #322
Merged
Merged
Conversation
inducerforce-pushed
the
more-types-2025-06
branch
2 times, most recently
from
June 26, 2025 00:26
2382812 to
f3515b8Compareinducer
marked this pull request as draft
June 26, 2025 02:52
inducerforce-pushed
the
more-types-2025-06
branch
3 times, most recently
from
June 26, 2025 16:32
600fea5 to
16ee9deCompareinducer
marked this pull request as ready for review
June 26, 2025 16:33
inducer
marked this pull request as draft
June 26, 2025 16:49
inducerforce-pushed
the
more-types-2025-06
branch
2 times, most recently
from
June 26, 2025 17:18
86bc1a0 to
8ee1030Compareinducer
marked this pull request as ready for review
June 26, 2025 17:30
inducerforce-pushed
the
more-types-2025-06
branch
2 times, most recently
from
June 26, 2025 18:55
b53a97a to
385649fCompare2 tasks
inducer
marked this pull request as draft
June 26, 2025 20:16
This improves many aspects of typing in arraycontext: - It improves type checking (and consistency) in the traversals. - It allows scalars consistently. - It adds some overloads for traversal functions. - It adds `rec_map_container`, which is simpler (and easier to type). - It makes array containers recognizable to the type checker. This works via a heuristic, by having `__array_ufunc__ == None`. - It adds more types in the base fake numpy and shifts some implementation aspects there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves many aspects of typing in arraycontext:
rec_map_container, which is simpler (and easier to type).This works via a heuristic, by having
__array_ufunc__ == None.Still needed: