Skip to content

Add array_equal to PyOpenCLArrayContext.np - #71

Merged
inducer merged 1 commit into
inducer:mainfrom
majosm:array-equal
Sep 22, 2021
Merged

Add array_equal to PyOpenCLArrayContext.np#71
inducer merged 1 commit into
inducer:mainfrom
majosm:array-equal

Conversation

@majosm

@majosmmajosm commented Aug 11, 2021

Copy link
Copy Markdown
Collaborator

Used by #46.

I'm not sure if there's a way to also make this work for PytatoPyOpenCLArrayContext? I ran into trouble with DataWrapper's __eq__ when I tried it.

@kaushikcfd

kaushikcfd commented Aug 11, 2021

Copy link
Copy Markdown
Collaborator

I ran into trouble with DataWrapper's eq when I tried it.

For pytato arrays Array.__eq__ is not compatiable with numpy. Maybe you want pt.equal. But we don't have (all|any) implemented for pytato arrays as of yet.

inducer
inducer reviewed Aug 11, 2021
View reviewed changes

@inducerinducer left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A few notes below.

Comment threadarraycontext/impl/pyopencl/fake_numpy.py Outdated
Comment threadarraycontext/impl/pyopencl/fake_numpy.py Outdated
@inducer

inducer commented Aug 11, 2021

Copy link
Copy Markdown
Owner

Unsubscribing... @-mention or request review once it's ready for a look or needs attention.

inducer
inducer reviewed Aug 12, 2021
View reviewed changes
Comment threadarraycontext/impl/pyopencl/fake_numpy.py
@majosm
majosmforce-pushed the array-equal branch 3 times, most recently from 6876333 to 2b2b0a4CompareAugust 13, 2021 20:27
@majosmmajosm mentioned this pull request Aug 26, 2021
Merged
@majosm
majosm marked this pull request as ready for review September 16, 2021 19:29
@majosm
majosm requested a review from inducerSeptember 16, 2021 19:29
inducer
inducer approved these changes Sep 20, 2021
View reviewed changes
Comment threadarraycontext/impl/pyopencl/fake_numpy.py Outdated
Comment threadarraycontext/impl/pyopencl/fake_numpy.py Outdated
@majosm
majosm requested a review from inducerSeptember 21, 2021 15:35
@inducer
inducer merged commit e98e577 into inducer:mainSep 22, 2021
@inducer

inducer commented Sep 22, 2021

Copy link
Copy Markdown
Owner

Thx!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexfiklalexfiklalexfikl left review comments
@kaushikcfdkaushikcfdkaushikcfd left review comments
@inducerinducerAwaiting requested review from inducer

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@majosm@kaushikcfd@inducer@alexfikl