Rename ArrayContainerT - #81
Conversation
majosm
commented
Aug 26, 2021
I had to remove a couple of the |
majosm
commented
Aug 26, 2021
I wonder if I could do something like: ? |
majosm
commented
Aug 26, 2021
That seems to work. Is it OK to add |
alexfikl
left a comment
There was a problem hiding this comment.
I'm definitely on board with the renaming, since it's a lot clearer!
I'm not very convinced the type annotations for the two *_impl functions are correct though, mostly because they nest generic functions and reuse the same TypeVar. There are some rules about that in PEP 484, but they don't seem to mention this setup.
This was definitely an issue before this PR, so not really a showstopper, just thinking out loud.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Alex Fikl <alexfikl@gmail.com>
inducer
left a comment
There was a problem hiding this comment.
LGTM. Thanks! I'll wait with merging until the CI issue from inducer/pytato#145 is done.
Closes#80.
I noticed a couple of spots where it makes sense (I think) to require containers, so I also added a
ContainerTin addition toArrayOrContainerT.