Skip to content

No more string tags - #245

Merged
inducer merged 21 commits into
mainfrom
pytools-tag-for-instruction
Mar 15, 2021
Merged

No more string tags#245
inducer merged 21 commits into
mainfrom
pytools-tag-for-instruction

Conversation

@inducer

@inducerinducer commented Mar 8, 2021•
edited
Loading

Copy link
Copy Markdown
Owner

@inducer
inducer requested a review from kaushikcfdMarch 8, 2021 00:04
@inducer
inducer marked this pull request as draft March 8, 2021 00:43
kaushikcfd
kaushikcfd reviewed Mar 8, 2021
View reviewed changes
Comment threadloopy/tools.py Outdated
kaushikcfd
kaushikcfd requested changes Mar 8, 2021
View reviewed changes

@kaushikcfdkaushikcfd left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I like the example use-case through UseStreamingStore tag.

Comment threadloopy/kernel/tools.py
Comment threadloopy/match.py Outdated
Comment threadloopy/match.py
Comment threadloopy/target/ispc.py
Base automatically changed from master to mainMarch 8, 2021 05:10
@inducerinducer mentioned this pull request Mar 8, 2021
Merged
@inducerinducer changed the title Normalize Instruction.tags to use pytools.tagNo more string tagsMar 11, 2021
@inducer
inducer marked this pull request as ready for review March 12, 2021 01:35
@inducer
inducer requested a review from kaushikcfdMarch 12, 2021 01:35
kaushikcfd
kaushikcfd approved these changes Mar 12, 2021
View reviewed changes

@kaushikcfdkaushikcfd left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor concern, otherwise LGTM. Thanks!

Comment threadloopy/kernel/instruction.py
@kaushikcfd

kaushikcfd commented Mar 15, 2021

Copy link
Copy Markdown
Collaborator

Good to go from my end.

@inducerinducer mentioned this pull request Mar 15, 2021
Open
@inducer

inducer commented Mar 15, 2021

Copy link
Copy Markdown
OwnerAuthor

Thanks for taking a look, and sorry about the nag!

@inducer
inducer merged commit e21e8f8 into mainMar 15, 2021
@inducer
inducer deleted the pytools-tag-for-instruction branch March 15, 2021 03:38
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaushikcfdkaushikcfdkaushikcfd approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@inducer@kaushikcfd