Skip to content

Map domain transformation v2 - #478

Merged
inducer merged 44 commits into
mainfrom
map-domain-transformation-v2
Sep 6, 2021
Merged

Map domain transformation v2#478
inducer merged 44 commits into
mainfrom
map-domain-transformation-v2

Conversation

@jdsteve2

@jdsteve2jdsteve2 commented Aug 5, 2021

Copy link
Copy Markdown
Contributor

Add map_domain transformation.

This PR/branch is one of two parents of child PR/branch: Update dependencies during transformation

This PR/branch was moved here to independent, top-level PR/branch from old PR/branch: Add map_domain transformation.

Note that to keep these branches independent, some helper functions are defined in both branches.

@jdsteve2
add map_domain to loopy init
f719cfb
@jdsteve2
copy in map_domain funcs from old branch (add-map-domain-transformation)
2780237
@jdsteve2
define add_and_name_isl_dims and add_eq_isl_constraint_from_names loc…
e5edf40
…ally for now (previously were defined in schedule checking utils before this code was moved to independent branch)
@jdsteve2
define ensure_dim_names_match_and_align locally for now (previously w…
c6320d8
…as defined in schedule checking utils before this code was moved to independent branch)
This was referenced Aug 5, 2021
Draft
Draft
@jdsteve2
remove FIXME now that dim_type usage is consistent
34b7d8f
@jdsteve2
add better encapsulation for case where domain map has fewer dims tha…
62d711b
…n domains (with _apply_identity_for_missing_map_dims func)
@jdsteve2
improve var names and error message related to mismatching of transfo…
05acfbe
…rm map and inames domain
@jdsteve2
test map_domain cases where there is a mismatch between the inames in…
8b3195f
… the transform map and the inames in a domain
@jdsteve2
enforce that transform map in map_domain must apply to exactly one do…
6ee3cf0
…main
@jdsteve2
test map validity checking/errors in map_domain
f5b2257
@jdsteve2
remove map applicability logic from process_set
fddd305
@jdsteve2
update expected error string for map_domain test
be524ff
@jdsteve2
Merge branch 'main' into map-domain-transformation-v2
3add15b
@jdsteve2
remove arg from map_domain
e5b765c
@jdsteve2
in map_domain, error if there are any loop priorities/nest constraint…
c0a613c
…s involving the mapped inames
@jdsteve2
add test for map_domain error when there are any loop priorities/nest…
88ebe1a
… constraints involving the mapped inames
@jdsteve2
in map_domain, rename isl_map->transform_map; add docstring
13356df
@jdsteve2
clean up code for map_domain; clarify error message a bit
ab6076a
@jdsteve2
add map_domain test for handling of case where stmt.within_inames con…
d710f8d
…tains some but not all mapped inames
@jdsteve2
clarify comment in map_domain
48e2c9a
@jdsteve2
remove fixme
6e7951a
@jdsteve2
clean up and document _apply_identity_for_missing_map_dims
061a8ec
@jdsteve2
document _error_if_any_iname_in_constraint
fc0e265
@jdsteve2
minor changes to error messages in _MapDomainMapper and _find_aff_sub…
aee9c83
…st_from_map
@jdsteve2
vim fold markers for map_domain and associated functions
468819d
@jdsteve2
final cleanup of map_domain functions
1073f99
@jdsteve2
jdsteve2 marked this pull request as ready for review August 28, 2021 21:35
@jdsteve2

jdsteve2 commented Aug 28, 2021

Copy link
Copy Markdown
ContributorAuthor

@inducer This is ready for you to look at. I haven't yet expressed affine_map_inames in terms of map_domain, which I will work on next, but this much can be viewed independently. Other than that, all of the FIXMEs that we decided to prioritize are done.

inducer
inducer reviewed Aug 30, 2021
View reviewed changes

@inducerinducer left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, thanks! Just a few wrinkles, then this should be good to go.

Comment threadloopy/transform/iname.py Outdated
Comment threadloopy/transform/iname.py Outdated
Comment threadloopy/transform/iname.py
Comment threadloopy/transform/iname.py Outdated
Comment threadloopy/transform/iname.py Outdated
Comment threadtest/test_transform.py
Comment threadtest/test_transform.py Outdated
Comment threadtest/test_transform.py Outdated
jdsteve2and others added 17 commits August 31, 2021 16:46
@jdsteve2@inducer
Update loopy/transform/iname.py
e2ff759
update arg without copy in _find_and_rename_dim
Co-authored-by: Andreas Klöckner <inform@tiker.net>
@jdsteve2@inducer
Update loopy/transform/iname.py
4ce6c7a
in map_domain, use <= instead of issubset
Co-authored-by: Andreas Klöckner <inform@tiker.net>
@jdsteve2
Merge branch 'main' into map-domain-transformation-v2
dbc3954
@jdsteve2
move add_and_name_isl_dims, add_eq_isl_constraint_from_names, and fin…
a1534bd
…d_and_rename_dim into isl_helpers
@jdsteve2
rename isl_map to isl_obj when sets are also allowed; remove comments…
3281b76
… about functions defined in other branches
@jdsteve2
docstrings for add_and_name_isl_dims, add_eq_isl_constraint_from_name…
c7ac1f2
…s, and find_and_rename_dim
@jdsteve2
remove unnecessary variable renaming in add_and_name_dims
693ee86
@jdsteve2
since find_and_rename_dim is only used for one dim type at a time, ma…
b8c3400
…ke it only accept a single dim type arg
@jdsteve2
more detailed documentation for _apply_identity_for_missing_map_dims
9801d1c
@jdsteve2
in map_domain, don't recompute subst_from_map for no reason
09703eb
@jdsteve2
use auto_test_vs_ref in test_map_domain_vs_split_iname
3d24d43
@jdsteve2
use get_attr instead of try/except to check for loop_nest_constraints…
6594873
… attribute in kernel; also clarify purpose of some tests
@jdsteve2
shrink problem size to make test_map_domain_transform_map_validity_an…
9404594
…d_errors run faster
@jdsteve2
use same loop prioritization regardless of whether we're using priori…
8188649
…tize_loops() or constrain_loop_nesting()
@jdsteve2
further clarification in comments about purpose of some map-domain tests
434f04b
@jdsteve2
tell pylint to chill out about a missing attribute
332ebf5
@jdsteve2
tell pylint to chill out about a missing attribute
6e1f1d9
@jdsteve2
jdsteve2force-pushed the map-domain-transformation-v2 branch from 332ebf5 to 6e1f1d9CompareSeptember 1, 2021 00:34
@jdsteve2

jdsteve2 commented Sep 1, 2021

Copy link
Copy Markdown
ContributorAuthor

Looking great, thanks! Just a few wrinkles, then this should be good to go.

Thanks! I have ironed the wrinkles and it's ready for you when you get a chance. In case it helps, here's a diff of the changes since yesterday.

@inducer
inducer merged commit 1032cd2 into mainSep 6, 2021
@inducer
inducer deleted the map-domain-transformation-v2 branch September 6, 2021 22:16
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@inducerinducerinducer left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jdsteve2@inducer