Use memoized variants for mapping expressions - #603
Merged
Conversation
kaushikcfdforce-pushed
the
memoized_mappers
branch
4 times, most recently
from
April 26, 2022 21:41
3561b6b to
1dffd33Comparekaushikcfdforce-pushed
the
memoized_mappers
branch
6 times, most recently
from
May 4, 2022 04:50
5aa13c2 to
65593eeCompareinducer
commented
May 4, 2022
Owner
Something like #611 (currently set to automerge if it passes) may address the failure in the Firedrake CI. |
kaushikcfd
commented
May 4, 2022
CollaboratorAuthor
Thanks, pulled from |
inducer
commented
May 4, 2022
Owner
Just this PR, or one of the other ones? |
Owner
|
CollaboratorAuthor
I think the variance between runs is pretty high, an older run: inducer/pymbolic#91 (a week ago) has 49 mins of potential CI time. So, not surprising quite surprising in that case. Looks mostly like a false alarm. (sorry) |
inducer
commented
May 6, 2022
Owner
This looks good to me. Thanks for working on it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See inducer/pymbolic#90.
Draft because: