Skip to content

Precise dependencies compatibility - #785

Closed
a-alveyblanc wants to merge 1 commit into
inducer:mainfrom
a-alveyblanc:precise-dependencies-compatibility
Closed

Precise dependencies compatibility#785
a-alveyblanc wants to merge 1 commit into
inducer:mainfrom
a-alveyblanc:precise-dependencies-compatibility

Conversation

@a-alveyblanc

@a-alveyblanca-alveyblanc commented Jun 15, 2023

Copy link
Copy Markdown
Contributor
  • Adds HappensAfter data structure
  • Adds routine to compute lexicographic order of statements (found in loopy/kernel/dependency.py)
  • Updates InstructionBase to accommodate precise dependency semantics (depends_on -> happens_after)
  • Other changes to remedy the fact that depends_on is now happens_after

Needs:

Comment threadloopy/kernel/creation.py Outdated
Comment threadloopy/kernel/creation.py Outdated
Comment threadloopy/kernel/dependency.py Outdated
Comment threadloopy/kernel/instruction.py Outdated
Comment threadloopy/kernel/instruction.py Outdated
Comment threadloopy/kernel/instruction.py Outdated
Comment threadloopy/schedule/__init__.py Outdated
Comment threadloopy/schedule/__init__.py Outdated
Comment threadloopy/schedule/__init__.py Outdated
Comment threadtest/test_dependencies.py Outdated
@inducer
inducerforce-pushed the precise-dependencies-compatibility branch from 7222048 to 8b96893CompareAugust 1, 2023 18:02
@a-alveyblanc
a-alveyblancforce-pushed the precise-dependencies-compatibility branch from 8b96893 to 0cae494CompareMarch 26, 2024 02:29
@a-alveyblanc

Copy link
Copy Markdown
ContributorAuthor

@inducer This is ready for another look.

@inducer
inducerforce-pushed the precise-dependencies-compatibility branch 5 times, most recently from bcb356a to 47d3c01CompareAugust 6, 2024 20:27
@inducer
inducerforce-pushed the precise-dependencies-compatibility branch from 47d3c01 to 5c84e95CompareAugust 6, 2024 20:33

@inducerinducer left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, I will fix this up in the interest of getting it in soon.

Comment threadloopy/kernel/dependency.py Outdated
Comment on lines 66 to 91

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This snippet here would imply that the order of variables in a set is significant. This is not the case anywhere else in loopy, and I would prefer to not start having it be the case now. This behavior is also not documented.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So... I tried, but I ran out of time. 🙂 There's a bit of algorithmic work to be done here, and some important algorithmic pieces are in #690. We can discuss in more detail during our meeting Monday.

Rather than hijack this PR for my big pile of unrelated changes, that's now #864, which this depends on. The relevant pieces from #690 are also in #864, so you'll be able to rely on them.

@inducer
inducerforce-pushed the precise-dependencies-compatibility branch from b475e5a to 507792bCompareAugust 18, 2024 22:14
@inducerinducer mentioned this pull request Aug 19, 2024
@inducer
inducerforce-pushed the precise-dependencies-compatibility branch from 507792b to 587f381CompareAugust 19, 2024 12:22
@inducerinducer mentioned this pull request Aug 24, 2024
@inducer
inducerforce-pushed the precise-dependencies-compatibility branch from 587f381 to 1a6548cCompareAugust 25, 2024 04:41
@inducer
inducer marked this pull request as draft August 25, 2024 04:42
@inducerinducer closed this Feb 17, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@a-alveyblanc@inducer