Skip to content

Avoid de/allocations for zero-sized temporaries#840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
inducer merged 1 commit into from
May 1, 2024
Merged

Avoid de/allocations for zero-sized temporaries #840

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions loopy/target/pyopencl.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -817,10 +817,16 @@ def get_temporary_decls(self, codegen_state, schedule_index):

for tv in global_temporaries:
if not tv.base_storage:
nbytes_str = ecm(tv.nbytes, PREC_NONE, "i")
allocated_var_names.append(tv.name)
code_lines.append(Assign(tv.name,
f"allocator({nbytes_str})"))
if tv.nbytes:
# NB: This does not prevent all zero-size allocations,
# as sizes are parametric, and allocation size
# could turn out to be zero at runtime.
nbytes_str = ecm(tv.nbytes, PREC_NONE, "i")
allocated_var_names.append(tv.name)
code_lines.append(Assign(tv.name,
f"allocator({nbytes_str})"))
else:
code_lines.append(Assign(tv.name, "None"))

code_lines.append(Assign("_global_temporaries", "[{tvs}]".format(
tvs=", ".join(tv for tv in allocated_var_names))))
Expand Down