More fixes for functions - #503
Merged
Merged
Conversation
majosm
marked this pull request as ready for review
June 17, 2024 19:44
Collaborator
Author
|
@inducer I think this is ready for a look. (I'm getting some lingering doc errors about |
majosm
force-pushed
the
more-function-fixes
branch
from
June 17, 2024 22:48
9d8b85f to
de0ad07
Compare
majosm
force-pushed
the
more-function-fixes
branch
2 times, most recently
from
June 28, 2024 15:12
a67b520 to
72bf01d
Compare
inducer
force-pushed
the
more-function-fixes
branch
from
July 1, 2024 21:07
72bf01d to
ecf1532
Compare
majosm
force-pushed
the
more-function-fixes
branch
from
July 2, 2024 01:44
ecf1532 to
d073b9f
Compare
inducer
reviewed
Jul 2, 2024
inducer
left a comment
Owner
There was a problem hiding this comment.
Thanks for working on this. Just a few hopefully relatively simple things, then this should be good to go.
majosm
force-pushed
the
more-function-fixes
branch
3 times, most recently
from
July 11, 2024 20:21
9c34aa1 to
11eaa85
Compare
Collaborator
Author
|
Should be ready for another look. (Previous review was up through the second "add FIXME".) |
doesn't make sense, since it doesn't return anything
now done in arraycontext
majosm
force-pushed
the
more-function-fixes
branch
from
July 25, 2024 20:53
11eaa85 to
1e7c71d
Compare
Collaborator
Author
Ready for real this time. @inducer |
default map_call implementation was removed from CombineMapper, so it needs to be here
Merged
inducer
reviewed
Jul 29, 2024
| def __init__(self) -> None: | ||
| super().__init__() | ||
| self._visited_nodes: set[Any] = set() | ||
| self._visited_arrays_or_names: set[Any] = set() |
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Probably easier to read commit by commit.)