No inherited attrs - #520
Conversation
|
|
||
| @attrs.frozen(eq=False, repr=False, hash=True, cache_hash=True) | ||
| class NamedArray(Array): | ||
| class NamedArray(_SuppliedAxesAndTagsMixin, Array): |
There was a problem hiding this comment.
Should this be "_SuppliedAxesAndTagsMixin"?
There was a problem hiding this comment.
What do you mean? Are you saying this should not inherit from Array?
There was a problem hiding this comment.
I meant NamedArray should not be taggable, instead it should propagate the tags and axes from the array it points to.
There was a problem hiding this comment.
The difficulty with that is that tags on NamedArrays can then no longer be changed (because we would have to change the DictOfNamedArrays, but that gets pointed to by potentially a bunch more NamedArrays.
Are we expecting that we can usefully call _with_new_tags on all Arrays?
There was a problem hiding this comment.
DistributedSendRefHolder also currently can't have its tags changed, but that at least could be implemented.
21463da to
be5942c
Compare
be5942c to
22d6fd3
Compare
No description provided.