Add mappers for direct solver - #152
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
inducer
left a comment
There was a problem hiding this comment.
Thanks! Some comments from a quick scroll.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
aab3e5b to
7a1a23fCompare
inducer
left a comment
There was a problem hiding this comment.
Thanks! A few more things below. LGTM once these are addressed.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
inducer
commented
May 19, 2022
Unsubscribing... @-mention or request review once it's ready for a look or needs attention. |
a844660 to
aaf1db8Compareinducer
commented
Jun 5, 2022
This looks good, thanks! |
This rips out the mappers from #30 for some discussion + tests. The new mappers are
IntGTermCollector: removes all non-IntGterms in the expression and all non-constant coefficients.KernelTransformationRemover: removes transforms fromIntGkernels.DOFDescriptorReplacer: re-tags an expression.They're basically used to clean up a given expression for source->proxy or proxy->target evaluation, which
IntGterms, since those are only diagonal operators.TODO: