(strict) typing for __init__.py, mpi.py, graph.py - #176
Open
matthiasdiener wants to merge 9 commits into
Open
Conversation
matthiasdienerforce-pushed
the
typing-record
branch
3 times, most recently
from
March 14, 2023 01:53
71cadf4 to
94b706bComparematthiasdienerforce-pushed
the
typing-record
branch
from
March 14, 2023 01:55
94b706b to
8a14dfbComparematthiasdienerforce-pushed
the
typing-record
branch
from
March 14, 2023 23:00
5494abf to
953870bComparematthiasdiener
marked this pull request as ready for review
March 14, 2023 23:03
matthiasdiener
commented
Mar 14, 2023
ContributorAuthor
This is ready for review. I can break the changes into smaller pieces if you prefer. |
| return result | ||
| comb = MovedFunctionDeprecationWrapper(math.comb, deadline=2023) | ||
| def perm(n: SupportsIndex, # type: ignore[misc] |
ContributorAuthor
There was a problem hiding this comment.
I removed this function since pytools requires Python 3.8+ currently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.