Uh oh!
There was an error while loading. Please reload this page.
feat(Accordion): Clockface 4 Updates - #859
Merged
Merged
Conversation
ChitlangeSahasforce-pushed
the
clockface_4_running_master
branch
from
October 6, 2022 05:31
5117741 to
27afbadCompare| isExpanded, | ||
| setExpanded, | ||
| iconPlacementPosition: hasBody ? iconPlacementPosition : Direction.None, | ||
| iconPlacementPosition: hasBody ? Direction.Left : Direction.None, |
ContributorAuthor
There was a problem hiding this comment.
We want to force left placement of icons for more consistency.
| style={{justifyContent: 'none', alignItems: 'start', display: 'block'}} | ||
| > | ||
| <Accordion | ||
| iconPlacement={ |
ContributorAuthor
There was a problem hiding this comment.
delete that option from storybook
ChitlangeSahasforce-pushed
the
clockface_4_running_master
branch
from
October 6, 2022 05:34
27afbad to
c9726e3Compare| </Accordion.AccordionHeader> | ||
| <Accordion.AccordionBodyItem> | ||
| <span> | ||
| This is your detailed body. This is your detailed body. This is |
ContributorAuthor
There was a problem hiding this comment.
Found this annoying, so changed it.
ContributorAuthor
There was a problem hiding this comment.
Lorem ipsum is a pretty standard replacement.
ChitlangeSahasforce-pushed
the
clockface_4_running_master
branch
from
October 6, 2022 05:37
c9726e3 to
f0f85f9Compare1. Colors and Icon placement 2. Fixed the icon bug for when accordion opens/closes (it didn't change icons) 3. Updated storybook
ChitlangeSahasforce-pushed
the
clockface_4_running_master
branch
from
October 6, 2022 05:47
f0f85f9 to
642d8a7Compare
Comment on lines
+77
to
+79
| &--no-body { | ||
| margin-left: 25px; | ||
| } |
ContributorAuthor
There was a problem hiding this comment.
previous, looked off.
ChitlangeSahas
marked this pull request as ready for review
October 6, 2022 06:08
ChitlangeSahas
requested review from
a team, juliajames12 and mavarius
as code ownersOctober 6, 2022 06:08
ChitlangeSahas
commented
Oct 18, 2022
ContributorAuthor
Part of #6090 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #822
Accordion updates for Clockface 4 to match figma.
Screen.Recording.2022-10-05.at.11.11.18.PM.mov