feat(Dropdowns): Clockface 4 dropdown updates by ChitlangeSahas · Pull Request #876 · influxdata/clockface

ChitlangeSahas · 2022-10-18T04:29:28Z

Closes#838

Couple screenshots:

SelectDropdown:

TypeAheadDropdown:

CreateableTypeAheadDropdown:

MultiSelect:

Updated documentation to reflect changes
Added entry to top of Changelog with link to PR (not issue)
Tests pass
Peer reviewed and approved
Signed CLA (if not already signed)

ChitlangeSahas · 2022-10-18T04:31:22Z

+ margin-right: 2px;
+ margin-left: 1px;


These two stick out, but they're just to please the absolute positioned, Scrollbar library we're using

Can this be solved using position and left and right rather than with using margins? Semantically, there's a big difference between position and margin, and we should use positioning for laying things out, and margins for when we need space around an element. I'm not super familiar with how this is used, though

Got you! I'll try that!

It still cuts off the right end of it, I think this is what is happening:
So, when I add the margin, the border falls under the available space.
Unfortunately, I am not able to change the width of the inner wrapper, since it's controlled by the react-custom-scrollbar library.

This was always a problem, but we never noticed because we didn't use borders as an indicator for being selected. Now that we use the border, we see that the 1px of the right is cut off.

is it causing problems to have the border? julia and i also discussed maybe not needing a background color at all on selected items. we included it because that's what we have now—adjusted to be lower contrast so it's less distracting—but i think the selected state for the radio buttons and checkboxes has enough contrast that we might not need the background color+border as well. let me know what you think. @ChitlangeSahas @hoorayimhelping @juliajames12

Currently I implemented it in the way figma looks, with no issues. But if we decide to remove the border+background, let me know I can make a future ticket and address that! 👍

talked to sahas—it's a big of a bigger project to reevaluate these, so we'll keep it as-is for now and tweak it later if we find we need to once we test it out

ChitlangeSahas · 2022-10-18T04:31:57Z

+ @include buttonColorModifier(
+ $cf-turquoise,
+ $cf-turquoise,
+ $cf-grey-1,
+ $cf-grey-1
+ );


Just ran prettier, hence the diff.

wdoconnell · 2022-10-18T16:16:10Z

 @include dropdownItemStyles();
 font-weight: $cf-font-weight--medium;
+ text-transform: uppercase;
+ color: #88889b;


Since this is just a divider - does text-transform: uppercase have any effect?

The dividers have text, optionally 👍

Gotcha - thanks!

ChitlangeSahas · 2022-10-18T04:29:28Z

Closes#838

Couple screenshots:

SelectDropdown:

TypeAheadDropdown:

CreateableTypeAheadDropdown:

MultiSelect:

Updated documentation to reflect changes
Added entry to top of Changelog with link to PR (not issue)
Tests pass
Peer reviewed and approved
Signed CLA (if not already signed)

ChitlangeSahas · 2022-10-18T04:31:22Z

+ margin-right: 2px;
+ margin-left: 1px;


These two stick out, but they're just to please the absolute positioned, Scrollbar library we're using

Can this be solved using position and left and right rather than with using margins? Semantically, there's a big difference between position and margin, and we should use positioning for laying things out, and margins for when we need space around an element. I'm not super familiar with how this is used, though

Got you! I'll try that!

It still cuts off the right end of it, I think this is what is happening:
So, when I add the margin, the border falls under the available space.
Unfortunately, I am not able to change the width of the inner wrapper, since it's controlled by the react-custom-scrollbar library.

This was always a problem, but we never noticed because we didn't use borders as an indicator for being selected. Now that we use the border, we see that the 1px of the right is cut off.

is it causing problems to have the border? julia and i also discussed maybe not needing a background color at all on selected items. we included it because that's what we have now—adjusted to be lower contrast so it's less distracting—but i think the selected state for the radio buttons and checkboxes has enough contrast that we might not need the background color+border as well. let me know what you think. @ChitlangeSahas @hoorayimhelping @juliajames12

Currently I implemented it in the way figma looks, with no issues. But if we decide to remove the border+background, let me know I can make a future ticket and address that! 👍

talked to sahas—it's a big of a bigger project to reevaluate these, so we'll keep it as-is for now and tweak it later if we find we need to once we test it out

ChitlangeSahas · 2022-10-18T04:31:57Z

+ @include buttonColorModifier(
+ $cf-turquoise,
+ $cf-turquoise,
+ $cf-grey-1,
+ $cf-grey-1
+ );


Just ran prettier, hence the diff.

wdoconnell · 2022-10-18T16:16:10Z

 @include dropdownItemStyles();
 font-weight: $cf-font-weight--medium;
+ text-transform: uppercase;
+ color: #88889b;


Since this is just a divider - does text-transform: uppercase have any effect?

The dividers have text, optionally 👍

Gotcha - thanks!

ChitlangeSahas · 2022-10-18T04:29:28Z

Closes#838

Couple screenshots:

SelectDropdown:

TypeAheadDropdown:

CreateableTypeAheadDropdown:

MultiSelect:

Updated documentation to reflect changes
Added entry to top of Changelog with link to PR (not issue)
Tests pass
Peer reviewed and approved
Signed CLA (if not already signed)

ChitlangeSahas · 2022-10-18T04:31:22Z

+ margin-right: 2px;
+ margin-left: 1px;


These two stick out, but they're just to please the absolute positioned, Scrollbar library we're using

Can this be solved using position and left and right rather than with using margins? Semantically, there's a big difference between position and margin, and we should use positioning for laying things out, and margins for when we need space around an element. I'm not super familiar with how this is used, though

Got you! I'll try that!

It still cuts off the right end of it, I think this is what is happening:
So, when I add the margin, the border falls under the available space.
Unfortunately, I am not able to change the width of the inner wrapper, since it's controlled by the react-custom-scrollbar library.

This was always a problem, but we never noticed because we didn't use borders as an indicator for being selected. Now that we use the border, we see that the 1px of the right is cut off.

is it causing problems to have the border? julia and i also discussed maybe not needing a background color at all on selected items. we included it because that's what we have now—adjusted to be lower contrast so it's less distracting—but i think the selected state for the radio buttons and checkboxes has enough contrast that we might not need the background color+border as well. let me know what you think. @ChitlangeSahas @hoorayimhelping @juliajames12

Currently I implemented it in the way figma looks, with no issues. But if we decide to remove the border+background, let me know I can make a future ticket and address that! 👍

talked to sahas—it's a big of a bigger project to reevaluate these, so we'll keep it as-is for now and tweak it later if we find we need to once we test it out

ChitlangeSahas · 2022-10-18T04:31:57Z

+ @include buttonColorModifier(
+ $cf-turquoise,
+ $cf-turquoise,
+ $cf-grey-1,
+ $cf-grey-1
+ );


Just ran prettier, hence the diff.

wdoconnell · 2022-10-18T16:16:10Z

 @include dropdownItemStyles();
 font-weight: $cf-font-weight--medium;
+ text-transform: uppercase;
+ color: #88889b;


Since this is just a divider - does text-transform: uppercase have any effect?

The dividers have text, optionally 👍

Gotcha - thanks!

ChitlangeSahas · 2022-10-18T04:29:28Z

Closes#838

Couple screenshots:

SelectDropdown:

TypeAheadDropdown:

CreateableTypeAheadDropdown:

MultiSelect:

Updated documentation to reflect changes
Added entry to top of Changelog with link to PR (not issue)
Tests pass
Peer reviewed and approved
Signed CLA (if not already signed)

ChitlangeSahas · 2022-10-18T04:31:22Z

+ margin-right: 2px;
+ margin-left: 1px;


These two stick out, but they're just to please the absolute positioned, Scrollbar library we're using

Can this be solved using position and left and right rather than with using margins? Semantically, there's a big difference between position and margin, and we should use positioning for laying things out, and margins for when we need space around an element. I'm not super familiar with how this is used, though

Got you! I'll try that!

It still cuts off the right end of it, I think this is what is happening:
So, when I add the margin, the border falls under the available space.
Unfortunately, I am not able to change the width of the inner wrapper, since it's controlled by the react-custom-scrollbar library.

This was always a problem, but we never noticed because we didn't use borders as an indicator for being selected. Now that we use the border, we see that the 1px of the right is cut off.

is it causing problems to have the border? julia and i also discussed maybe not needing a background color at all on selected items. we included it because that's what we have now—adjusted to be lower contrast so it's less distracting—but i think the selected state for the radio buttons and checkboxes has enough contrast that we might not need the background color+border as well. let me know what you think. @ChitlangeSahas @hoorayimhelping @juliajames12

Currently I implemented it in the way figma looks, with no issues. But if we decide to remove the border+background, let me know I can make a future ticket and address that! 👍

talked to sahas—it's a big of a bigger project to reevaluate these, so we'll keep it as-is for now and tweak it later if we find we need to once we test it out

ChitlangeSahas · 2022-10-18T04:31:57Z

+ @include buttonColorModifier(
+ $cf-turquoise,
+ $cf-turquoise,
+ $cf-grey-1,
+ $cf-grey-1
+ );


Just ran prettier, hence the diff.

wdoconnell · 2022-10-18T16:16:10Z

 @include dropdownItemStyles();
 font-weight: $cf-font-weight--medium;
+ text-transform: uppercase;
+ color: #88889b;


Since this is just a divider - does text-transform: uppercase have any effect?

The dividers have text, optionally 👍

Gotcha - thanks!

ChitlangeSahas · 2022-10-18T04:29:28Z

Closes#838

Couple screenshots:

SelectDropdown:

TypeAheadDropdown:

CreateableTypeAheadDropdown:

MultiSelect:

Updated documentation to reflect changes
Added entry to top of Changelog with link to PR (not issue)
Tests pass
Peer reviewed and approved
Signed CLA (if not already signed)

ChitlangeSahas · 2022-10-18T04:31:22Z

+ margin-right: 2px;
+ margin-left: 1px;


These two stick out, but they're just to please the absolute positioned, Scrollbar library we're using

Can this be solved using position and left and right rather than with using margins? Semantically, there's a big difference between position and margin, and we should use positioning for laying things out, and margins for when we need space around an element. I'm not super familiar with how this is used, though

Got you! I'll try that!

It still cuts off the right end of it, I think this is what is happening:
So, when I add the margin, the border falls under the available space.
Unfortunately, I am not able to change the width of the inner wrapper, since it's controlled by the react-custom-scrollbar library.

This was always a problem, but we never noticed because we didn't use borders as an indicator for being selected. Now that we use the border, we see that the 1px of the right is cut off.

is it causing problems to have the border? julia and i also discussed maybe not needing a background color at all on selected items. we included it because that's what we have now—adjusted to be lower contrast so it's less distracting—but i think the selected state for the radio buttons and checkboxes has enough contrast that we might not need the background color+border as well. let me know what you think. @ChitlangeSahas @hoorayimhelping @juliajames12

Currently I implemented it in the way figma looks, with no issues. But if we decide to remove the border+background, let me know I can make a future ticket and address that! 👍

talked to sahas—it's a big of a bigger project to reevaluate these, so we'll keep it as-is for now and tweak it later if we find we need to once we test it out

ChitlangeSahas · 2022-10-18T04:31:57Z

+ @include buttonColorModifier(
+ $cf-turquoise,
+ $cf-turquoise,
+ $cf-grey-1,
+ $cf-grey-1
+ );


Just ran prettier, hence the diff.

wdoconnell · 2022-10-18T16:16:10Z

 @include dropdownItemStyles();
 font-weight: $cf-font-weight--medium;
+ text-transform: uppercase;
+ color: #88889b;


Since this is just a divider - does text-transform: uppercase have any effect?

The dividers have text, optionally 👍

Gotcha - thanks!

ChitlangeSahas · 2022-10-18T04:29:28Z

Closes#838

Couple screenshots:

SelectDropdown:

TypeAheadDropdown:

CreateableTypeAheadDropdown:

MultiSelect:

Updated documentation to reflect changes
Added entry to top of Changelog with link to PR (not issue)
Tests pass
Peer reviewed and approved
Signed CLA (if not already signed)

ChitlangeSahas · 2022-10-18T04:31:22Z

+ margin-right: 2px;
+ margin-left: 1px;


These two stick out, but they're just to please the absolute positioned, Scrollbar library we're using

Can this be solved using position and left and right rather than with using margins? Semantically, there's a big difference between position and margin, and we should use positioning for laying things out, and margins for when we need space around an element. I'm not super familiar with how this is used, though

Got you! I'll try that!

It still cuts off the right end of it, I think this is what is happening:
So, when I add the margin, the border falls under the available space.
Unfortunately, I am not able to change the width of the inner wrapper, since it's controlled by the react-custom-scrollbar library.

This was always a problem, but we never noticed because we didn't use borders as an indicator for being selected. Now that we use the border, we see that the 1px of the right is cut off.

is it causing problems to have the border? julia and i also discussed maybe not needing a background color at all on selected items. we included it because that's what we have now—adjusted to be lower contrast so it's less distracting—but i think the selected state for the radio buttons and checkboxes has enough contrast that we might not need the background color+border as well. let me know what you think. @ChitlangeSahas @hoorayimhelping @juliajames12

Currently I implemented it in the way figma looks, with no issues. But if we decide to remove the border+background, let me know I can make a future ticket and address that! 👍

talked to sahas—it's a big of a bigger project to reevaluate these, so we'll keep it as-is for now and tweak it later if we find we need to once we test it out

ChitlangeSahas · 2022-10-18T04:31:57Z

+ @include buttonColorModifier(
+ $cf-turquoise,
+ $cf-turquoise,
+ $cf-grey-1,
+ $cf-grey-1
+ );


Just ran prettier, hence the diff.

wdoconnell · 2022-10-18T16:16:10Z

 @include dropdownItemStyles();
 font-weight: $cf-font-weight--medium;
+ text-transform: uppercase;
+ color: #88889b;


Since this is just a divider - does text-transform: uppercase have any effect?

The dividers have text, optionally 👍

Gotcha - thanks!

ChitlangeSahas · 2022-10-18T04:29:28Z

Closes#838

Couple screenshots:

SelectDropdown:

TypeAheadDropdown:

CreateableTypeAheadDropdown:

MultiSelect:

Updated documentation to reflect changes
Added entry to top of Changelog with link to PR (not issue)
Tests pass
Peer reviewed and approved
Signed CLA (if not already signed)

ChitlangeSahas · 2022-10-18T04:31:22Z

+ margin-right: 2px;
+ margin-left: 1px;


These two stick out, but they're just to please the absolute positioned, Scrollbar library we're using

Can this be solved using position and left and right rather than with using margins? Semantically, there's a big difference between position and margin, and we should use positioning for laying things out, and margins for when we need space around an element. I'm not super familiar with how this is used, though

Got you! I'll try that!

It still cuts off the right end of it, I think this is what is happening:
So, when I add the margin, the border falls under the available space.
Unfortunately, I am not able to change the width of the inner wrapper, since it's controlled by the react-custom-scrollbar library.

This was always a problem, but we never noticed because we didn't use borders as an indicator for being selected. Now that we use the border, we see that the 1px of the right is cut off.

is it causing problems to have the border? julia and i also discussed maybe not needing a background color at all on selected items. we included it because that's what we have now—adjusted to be lower contrast so it's less distracting—but i think the selected state for the radio buttons and checkboxes has enough contrast that we might not need the background color+border as well. let me know what you think. @ChitlangeSahas @hoorayimhelping @juliajames12

Currently I implemented it in the way figma looks, with no issues. But if we decide to remove the border+background, let me know I can make a future ticket and address that! 👍

talked to sahas—it's a big of a bigger project to reevaluate these, so we'll keep it as-is for now and tweak it later if we find we need to once we test it out

ChitlangeSahas · 2022-10-18T04:31:57Z

+ @include buttonColorModifier(
+ $cf-turquoise,
+ $cf-turquoise,
+ $cf-grey-1,
+ $cf-grey-1
+ );


Just ran prettier, hence the diff.

wdoconnell · 2022-10-18T16:16:10Z

 @include dropdownItemStyles();
 font-weight: $cf-font-weight--medium;
+ text-transform: uppercase;
+ color: #88889b;


Since this is just a divider - does text-transform: uppercase have any effect?

The dividers have text, optionally 👍

Gotcha - thanks!

ChitlangeSahas · 2022-10-18T04:29:28Z

Closes#838

Couple screenshots:

SelectDropdown:

TypeAheadDropdown:

CreateableTypeAheadDropdown:

MultiSelect:

Updated documentation to reflect changes
Added entry to top of Changelog with link to PR (not issue)
Tests pass
Peer reviewed and approved
Signed CLA (if not already signed)

ChitlangeSahas · 2022-10-18T04:31:22Z

+ margin-right: 2px;
+ margin-left: 1px;


These two stick out, but they're just to please the absolute positioned, Scrollbar library we're using

Can this be solved using position and left and right rather than with using margins? Semantically, there's a big difference between position and margin, and we should use positioning for laying things out, and margins for when we need space around an element. I'm not super familiar with how this is used, though

Got you! I'll try that!

It still cuts off the right end of it, I think this is what is happening:
So, when I add the margin, the border falls under the available space.
Unfortunately, I am not able to change the width of the inner wrapper, since it's controlled by the react-custom-scrollbar library.

This was always a problem, but we never noticed because we didn't use borders as an indicator for being selected. Now that we use the border, we see that the 1px of the right is cut off.

is it causing problems to have the border? julia and i also discussed maybe not needing a background color at all on selected items. we included it because that's what we have now—adjusted to be lower contrast so it's less distracting—but i think the selected state for the radio buttons and checkboxes has enough contrast that we might not need the background color+border as well. let me know what you think. @ChitlangeSahas @hoorayimhelping @juliajames12

Currently I implemented it in the way figma looks, with no issues. But if we decide to remove the border+background, let me know I can make a future ticket and address that! 👍

talked to sahas—it's a big of a bigger project to reevaluate these, so we'll keep it as-is for now and tweak it later if we find we need to once we test it out

ChitlangeSahas · 2022-10-18T04:31:57Z

+ @include buttonColorModifier(
+ $cf-turquoise,
+ $cf-turquoise,
+ $cf-grey-1,
+ $cf-grey-1
+ );


Just ran prettier, hence the diff.

wdoconnell · 2022-10-18T16:16:10Z

 @include dropdownItemStyles();
 font-weight: $cf-font-weight--medium;
+ text-transform: uppercase;
+ color: #88889b;


Since this is just a divider - does text-transform: uppercase have any effect?

The dividers have text, optionally 👍

Gotcha - thanks!

ChitlangeSahas added 2 commits October 17, 2022 21:20

feat(Dropdowns): Clockface 4 updates for Dropdowns
54bc89c

fix: hover effect
1049876

ChitlangeSahas changed the title ~~Clockface 4 dropdown updates~~feat(Dropdowns): Clockface 4 dropdown updatesOct 18, 2022

ChitlangeSahas changed the base branch from master to clockface-4-masterOctober 18, 2022 04:30

ChitlangeSahas commented Oct 18, 2022
View reviewed changes

ChitlangeSahas marked this pull request as ready for review October 18, 2022 04:32

ChitlangeSahas requested review from a team, juliajames12 and mavarius as code owners October 18, 2022 04:32

ChitlangeSahas requested a review from a teamOctober 18, 2022 04:32

ChitlangeSahas added 3 commits October 17, 2022 21:43

fix: input border
01b5c45

fix: input border focused
64c59bb

fix: line margin
0b4004a

wdoconnell reviewed Oct 18, 2022
View reviewed changes

wdoconnell approved these changes Oct 18, 2022
View reviewed changes

ChitlangeSahas requested a review from hoorayimhelping October 19, 2022 15:18

hoorayimhelping approved these changes Oct 19, 2022
View reviewed changes

ChitlangeSahas merged commit 0c4cb93 into clockface-4-masterOct 19, 2022

ChitlangeSahas deleted the clockface-4-dropdown_updates branch October 19, 2022 16:39

ChitlangeSahas added 2 commits October 17, 2022 21:20

feat(Dropdowns): Clockface 4 updates for Dropdowns
54bc89c

fix: hover effect
1049876

ChitlangeSahas changed the title ~~Clockface 4 dropdown updates~~feat(Dropdowns): Clockface 4 dropdown updatesOct 18, 2022

ChitlangeSahas changed the base branch from master to clockface-4-masterOctober 18, 2022 04:30

ChitlangeSahas commented Oct 18, 2022
View reviewed changes

ChitlangeSahas marked this pull request as ready for review October 18, 2022 04:32

ChitlangeSahas requested review from a team, juliajames12 and mavarius as code owners October 18, 2022 04:32

ChitlangeSahas requested a review from a teamOctober 18, 2022 04:32

ChitlangeSahas added 3 commits October 17, 2022 21:43

fix: input border
01b5c45

fix: input border focused
64c59bb

fix: line margin
0b4004a

wdoconnell reviewed Oct 18, 2022
View reviewed changes

wdoconnell approved these changes Oct 18, 2022
View reviewed changes

ChitlangeSahas requested a review from hoorayimhelping October 19, 2022 15:18

hoorayimhelping approved these changes Oct 19, 2022
View reviewed changes

ChitlangeSahas merged commit 0c4cb93 into clockface-4-masterOct 19, 2022

ChitlangeSahas deleted the clockface-4-dropdown_updates branch October 19, 2022 16:39

ChitlangeSahas added 2 commits October 17, 2022 21:20

feat(Dropdowns): Clockface 4 updates for Dropdowns
54bc89c

fix: hover effect
1049876

ChitlangeSahas changed the title ~~Clockface 4 dropdown updates~~feat(Dropdowns): Clockface 4 dropdown updatesOct 18, 2022

ChitlangeSahas changed the base branch from master to clockface-4-masterOctober 18, 2022 04:30

ChitlangeSahas commented Oct 18, 2022
View reviewed changes

ChitlangeSahas marked this pull request as ready for review October 18, 2022 04:32

ChitlangeSahas requested review from a team, juliajames12 and mavarius as code owners October 18, 2022 04:32

ChitlangeSahas requested a review from a teamOctober 18, 2022 04:32

ChitlangeSahas added 3 commits October 17, 2022 21:43

fix: input border
01b5c45

fix: input border focused
64c59bb

fix: line margin
0b4004a

wdoconnell reviewed Oct 18, 2022
View reviewed changes

wdoconnell approved these changes Oct 18, 2022
View reviewed changes

ChitlangeSahas requested a review from hoorayimhelping October 19, 2022 15:18

hoorayimhelping approved these changes Oct 19, 2022
View reviewed changes

ChitlangeSahas merged commit 0c4cb93 into clockface-4-masterOct 19, 2022

ChitlangeSahas deleted the clockface-4-dropdown_updates branch October 19, 2022 16:39

ChitlangeSahas added 2 commits October 17, 2022 21:20

feat(Dropdowns): Clockface 4 updates for Dropdowns
54bc89c

fix: hover effect
1049876

ChitlangeSahas changed the title ~~Clockface 4 dropdown updates~~feat(Dropdowns): Clockface 4 dropdown updatesOct 18, 2022

ChitlangeSahas changed the base branch from master to clockface-4-masterOctober 18, 2022 04:30

ChitlangeSahas commented Oct 18, 2022
View reviewed changes

ChitlangeSahas marked this pull request as ready for review October 18, 2022 04:32

ChitlangeSahas requested review from a team, juliajames12 and mavarius as code owners October 18, 2022 04:32

ChitlangeSahas requested a review from a teamOctober 18, 2022 04:32

ChitlangeSahas added 3 commits October 17, 2022 21:43

fix: input border
01b5c45

fix: input border focused
64c59bb

fix: line margin
0b4004a

wdoconnell reviewed Oct 18, 2022
View reviewed changes

wdoconnell approved these changes Oct 18, 2022
View reviewed changes

ChitlangeSahas requested a review from hoorayimhelping October 19, 2022 15:18

hoorayimhelping approved these changes Oct 19, 2022
View reviewed changes

ChitlangeSahas merged commit 0c4cb93 into clockface-4-masterOct 19, 2022

ChitlangeSahas deleted the clockface-4-dropdown_updates branch October 19, 2022 16:39

ChitlangeSahas added 2 commits October 17, 2022 21:20

feat(Dropdowns): Clockface 4 updates for Dropdowns
54bc89c

fix: hover effect
1049876

ChitlangeSahas changed the title ~~Clockface 4 dropdown updates~~feat(Dropdowns): Clockface 4 dropdown updatesOct 18, 2022

ChitlangeSahas changed the base branch from master to clockface-4-masterOctober 18, 2022 04:30

ChitlangeSahas commented Oct 18, 2022
View reviewed changes

ChitlangeSahas marked this pull request as ready for review October 18, 2022 04:32

ChitlangeSahas requested review from a team, juliajames12 and mavarius as code owners October 18, 2022 04:32

ChitlangeSahas requested a review from a teamOctober 18, 2022 04:32

ChitlangeSahas added 3 commits October 17, 2022 21:43

fix: input border
01b5c45

fix: input border focused
64c59bb

fix: line margin
0b4004a

wdoconnell reviewed Oct 18, 2022
View reviewed changes

wdoconnell approved these changes Oct 18, 2022
View reviewed changes

ChitlangeSahas requested a review from hoorayimhelping October 19, 2022 15:18

hoorayimhelping approved these changes Oct 19, 2022
View reviewed changes

ChitlangeSahas merged commit 0c4cb93 into clockface-4-masterOct 19, 2022

ChitlangeSahas deleted the clockface-4-dropdown_updates branch October 19, 2022 16:39

ChitlangeSahas added 2 commits October 17, 2022 21:20

feat(Dropdowns): Clockface 4 updates for Dropdowns
54bc89c

fix: hover effect
1049876

ChitlangeSahas changed the title ~~Clockface 4 dropdown updates~~feat(Dropdowns): Clockface 4 dropdown updatesOct 18, 2022

ChitlangeSahas changed the base branch from master to clockface-4-masterOctober 18, 2022 04:30

ChitlangeSahas commented Oct 18, 2022
View reviewed changes

ChitlangeSahas marked this pull request as ready for review October 18, 2022 04:32

ChitlangeSahas requested review from a team, juliajames12 and mavarius as code owners October 18, 2022 04:32

ChitlangeSahas requested a review from a teamOctober 18, 2022 04:32

ChitlangeSahas added 3 commits October 17, 2022 21:43

fix: input border
01b5c45

fix: input border focused
64c59bb

fix: line margin
0b4004a

wdoconnell reviewed Oct 18, 2022
View reviewed changes

wdoconnell approved these changes Oct 18, 2022
View reviewed changes

ChitlangeSahas requested a review from hoorayimhelping October 19, 2022 15:18

hoorayimhelping approved these changes Oct 19, 2022
View reviewed changes

ChitlangeSahas merged commit 0c4cb93 into clockface-4-masterOct 19, 2022

ChitlangeSahas deleted the clockface-4-dropdown_updates branch October 19, 2022 16:39

ChitlangeSahas added 2 commits October 17, 2022 21:20

feat(Dropdowns): Clockface 4 updates for Dropdowns
54bc89c

fix: hover effect
1049876

ChitlangeSahas changed the title ~~Clockface 4 dropdown updates~~feat(Dropdowns): Clockface 4 dropdown updatesOct 18, 2022

ChitlangeSahas changed the base branch from master to clockface-4-masterOctober 18, 2022 04:30

ChitlangeSahas commented Oct 18, 2022
View reviewed changes

ChitlangeSahas marked this pull request as ready for review October 18, 2022 04:32

ChitlangeSahas requested review from a team, juliajames12 and mavarius as code owners October 18, 2022 04:32

ChitlangeSahas requested a review from a teamOctober 18, 2022 04:32

ChitlangeSahas added 3 commits October 17, 2022 21:43

fix: input border
01b5c45

fix: input border focused
64c59bb

fix: line margin
0b4004a

wdoconnell reviewed Oct 18, 2022
View reviewed changes

wdoconnell approved these changes Oct 18, 2022
View reviewed changes

ChitlangeSahas requested a review from hoorayimhelping October 19, 2022 15:18

hoorayimhelping approved these changes Oct 19, 2022
View reviewed changes

ChitlangeSahas merged commit 0c4cb93 into clockface-4-masterOct 19, 2022

ChitlangeSahas deleted the clockface-4-dropdown_updates branch October 19, 2022 16:39

ChitlangeSahas added 2 commits October 17, 2022 21:20

feat(Dropdowns): Clockface 4 updates for Dropdowns
54bc89c

fix: hover effect
1049876

ChitlangeSahas changed the title ~~Clockface 4 dropdown updates~~feat(Dropdowns): Clockface 4 dropdown updatesOct 18, 2022

ChitlangeSahas changed the base branch from master to clockface-4-masterOctober 18, 2022 04:30

ChitlangeSahas commented Oct 18, 2022
View reviewed changes

ChitlangeSahas marked this pull request as ready for review October 18, 2022 04:32

ChitlangeSahas requested review from a team, juliajames12 and mavarius as code owners October 18, 2022 04:32

ChitlangeSahas requested a review from a teamOctober 18, 2022 04:32

ChitlangeSahas added 3 commits October 17, 2022 21:43

fix: input border
01b5c45

fix: input border focused
64c59bb

fix: line margin
0b4004a

wdoconnell reviewed Oct 18, 2022
View reviewed changes

wdoconnell approved these changes Oct 18, 2022
View reviewed changes

ChitlangeSahas requested a review from hoorayimhelping October 19, 2022 15:18

hoorayimhelping approved these changes Oct 19, 2022
View reviewed changes

ChitlangeSahas merged commit 0c4cb93 into clockface-4-masterOct 19, 2022

ChitlangeSahas deleted the clockface-4-dropdown_updates branch October 19, 2022 16:39

Uh oh!

Conversation

ChitlangeSahas commented Oct 18, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hoorayimhelpingOct 18, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

ChitlangeSahas commented Oct 18, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hoorayimhelpingOct 18, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

ChitlangeSahas commented Oct 18, 2022

Uh oh!

hoorayimhelpingOct 18, 2022•
edited
Loading

hoorayimhelpingOct 18, 2022•
edited
Loading

hoorayimhelpingOct 18, 2022•
edited
Loading