Skip to content

Runs on py3.11 - #1

Open
er-eis wants to merge 3 commits into
infopluscommerce:betafrom
er-eis:er-eis/bugfix/async-reserved-word
Open

er-eis wants to merge 3 commits into
infopluscommerce:betafrom
er-eis:er-eis/bugfix/async-reserved-word

Conversation

@er-eis

@er-eis er-eis commented Oct 2, 2023

Copy link
Copy Markdown
  1. async makes py3.11 mad:
../../../../../../venv/lib/python3.11/site-packages/Infoplus/__init__.py:19: in <module>
    from Infoplus.api.aisle_api import AisleApi
../../../../../../venv/lib/python3.11/site-packages/Infoplus/api/__init__.py:6: in <module>
    from Infoplus.api.aisle_api import AisleApi
E     File "/Users/ericeisenberg/programming/backend/venv/lib/python3.11/site-packages/Infoplus/api/aisle_api.py", line 129
E       async=params.get('async'),
E       ^^^^^
E   SyntaxError: invalid syntax

we switch it to _async instead

  1. removed the unused import:
from Infoplus.models.gs1128_label_dto import GS1128LabelDTO  # noqa: F401,E501

after the fixes w/ py3.11:

...
============================== 5 passed in 2.63s ===============================
PASSED [ 20%]PASSED [ 40%]PASSED [ 60%]PASSED [ 80%]PASSED [100%]
Process finished with exit code 0

@er-eis er-eis changed the title Replace async reserved word w/ _async Runs on py3.11 Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant