Conversation
Contributor
|
|
There was a problem hiding this comment.
🟡 Changes recommended
Hay ajustes necesarios en manifest (dependencias directas) y en el manejo/visualización del secreto para evitar problemas de instalación y reducir exposición del API secret.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Este PR incorpora en v18 un placeholder para almacenar el GA4 Measurement Protocol API Secret en website, exponiéndolo en Ajustes → Sitio web → Tracking & SEO para que el dato quede cargado antes de migrar a v19 (donde lo consumirá website_sale_google_analytics_4).
Changes:
- Agrega el campo
website.ga4_api_secret(Char) para persistir el valor en la DB. - Expone el campo vía
res.config.settings(related) y lo agrega a la vista de Ajustes de Website. - Incluye la nueva vista en el
__manifest__.py.
File summaries
| File | Description |
|---|---|
| google_tag_manager_advanced_tracking/views/res_config_settings_view.xml | Agrega el setting en Ajustes de Website para editar el GA4 API Secret. |
| google_tag_manager_advanced_tracking/models/website.py | Define el campo persistente ga4_api_secret en website. |
| google_tag_manager_advanced_tracking/models/res_config_settings.py | Expone el campo en settings con related="website_id.ga4_api_secret". |
| google_tag_manager_advanced_tracking/models/init.py | Importa los nuevos modelos. |
| google_tag_manager_advanced_tracking/manifest.py | Agrega la vista nueva a data. |
| google_tag_manager_advanced_tracking/init.py | Importa models para registrar los nuevos campos. |
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 3
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…r field Add a dummy `ga4_api_secret` Char on website (+ res.config.settings related field and its setting under Website > Tracking & SEO), mirroring the v19 field defined by website_sale_google_analytics_4. In v18 the field only stores the value: it lets clients generate and load their GA4 Measurement Protocol API Secret (server-side) before the v18->v19 upgrade. The GTM-deprecation Upgrade Line migrates the value to the homonymous field of website_sale_google_analytics_4 during the upgrade. Task #66923.
JrAdhoc
force-pushed
the
18.0-t-66923-jr
branch
from
September 4, 2026 14:59
571c304 to
1c5f85b
Compare
Contributor
|
@roboadhoc r+ bump |
roboadhoc
pushed a commit
that referenced
this pull request
Sep 4, 2026
…r field Add a dummy `ga4_api_secret` Char on website (+ res.config.settings related field and its setting under Website > Tracking & SEO), mirroring the v19 field defined by website_sale_google_analytics_4. In v18 the field only stores the value: it lets clients generate and load their GA4 Measurement Protocol API Secret (server-side) before the v18->v19 upgrade. The GTM-deprecation Upgrade Line migrates the value to the homonymous field of website_sale_google_analytics_4 during the upgrade. Task #66923. closes #481 Signed-off-by: Augusto Weiss <awe@adhoc.com.ar>
roboadhoc
added a commit
that referenced
this pull request
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Qué
Agrega un campo
ga4_api_secret(Char) enwebsite, su related enres.config.settingsy el setting correspondiente bajo Website → Tracking &SEO, justo debajo del setting nativo de Google Analytics.
Espeja el campo homónimo que en 19.0 define
website_sale_google_analytics_4.Por qué
En v18 el campo es un placeholder: solo almacena el valor. Permite que los
clientes que hoy están en 18.0 generen y carguen su GA4 Measurement Protocol
API Secret (server-side) antes de actualizar a 19.0, donde
website_sale_google_analytics_4lo consume para los eventos server-side(purchase, refund).
Durante el pase v18→v19, el Upgrade Line de deprecación del stack GTM migra el
valor al campo homónimo del módulo nuevo. Mantener el mismo nombre técnico
(
website.ga4_api_secret) es lo que hace que la columna sea reutilizable y eldato no se pierda.
Test plan
google_tag_manager_advanced_trackingen una base 18.0.aparece GA4 API Secret (Server-side) con su input.
website.ga4_api_secret.Task: https://www.adhoc.inc/odoo/project.task/66923