Uh oh!
There was an error while loading. Please reload this page.
JCL-402: HTTP error handling in JenaBodyHandlers - #1159
Merged
Conversation
NSeydouxforce-pushed
the
JCL-463/solid-client-throws-pd-exception
branch
from
April 14, 2024 21:22
da62735 to
aa53b0eCompareNSeydouxforce-pushed
the
JCL-457/jena-body-handler
branch
3 times, most recently
from
April 14, 2024 21:55
f6243cb to
f4b5906CompareNSeydoux
marked this pull request as ready for review
April 14, 2024 22:08
NSeydouxforce-pushed
the
JCL-457/jena-body-handler
branch
from
April 14, 2024 22:14
f4b5906 to
4b37262CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
NSeydouxforce-pushed
the
JCL-463/solid-client-throws-pd-exception
branch
4 times, most recently
from
April 17, 2024 07:25
fda4bb3 to
d722196CompareNSeydouxforce-pushed
the
JCL-457/jena-body-handler
branch
from
April 17, 2024 07:59
4b37262 to
39299b6CompareNSeydoux
changed the base branch from
JCL-463/solid-client-throws-pd-exception
to
JCL-460/problem-details-class-http-statusApril 17, 2024 07:59
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Base automatically changed from
JCL-460/problem-details-class-http-status to
mainApril 18, 2024 11:53
NSeydouxforce-pushed
the
JCL-457/jena-body-handler
branch
from
April 18, 2024 12:35
39299b6 to
f92ed37CompareNSeydoux
changed the base branch from
main
to
JCL-463/solid-client-throws-pd-exceptionApril 18, 2024 12:36
langsamu
approved these changes
Apr 19, 2024
NSeydouxforce-pushed
the
JCL-463/solid-client-throws-pd-exception
branch
2 times, most recently
from
April 23, 2024 07:45
a03f434 to
9e0967dCompareNSeydouxforce-pushed
the
JCL-457/jena-body-handler
branch
2 times, most recently
from
April 23, 2024 07:51
ffef3bc to
b8e402fCompare
Base automatically changed from
JCL-463/solid-client-throws-pd-exception to
mainApril 23, 2024 08:09
This deprecates the current methods in `JenaBodyHandlers`, and replaces them with similar method throwing an appropriate exception with error details on HTTP error instead of returning an empty dataset. The new method now have `Jena` in their name for this not to be a breaking change: `ofModel` becomes `ofJenaModel`, etc.
NSeydouxforce-pushed
the
JCL-457/jena-body-handler
branch
from
April 23, 2024 08:13
b8e402f to
63be5e6CompareNSeydoux
enabled auto-merge (squash)
April 23, 2024 08:13
acoburn added a commit
that referenced
this pull request
May 15, 2024
* Revert "JCL-402: RDF4J body handlers http error handling (#1162)" This reverts commit e03eb1e. * Revert "JCL-402: JSONB test coverage (#1184)" This reverts commit 52d485b. * Revert "JCL-402: HTTP error handling in JenaBodyHandlers (#1159)" This reverts commit 89534b4. * Move ProblemDetails to solid module, remove ClientHttpException * ProblemDetails to interface in API module
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is based on #1160, which should be reviewed first.
This deprecates the current methods in
JenaBodyHandlers, and replaces them with similar method throwing an appropriate exception with error details on HTTP error instead of returning an empty dataset. This makes use of the composable throwing body handler now exposed by theResponseinterface of theapimodule. The new method now haveJenain their name for this not to be a breaking change:ofModelbecomesofJenaModel, etc.