Uh oh!
There was an error while loading. Please reload this page.
JCL-335: issue request builder & grant approval calls - #422
Closed
timea-solid wants to merge 9 commits into
Closed
Conversation
timea-solid
marked this pull request as ready for review
April 14, 2023 16:47
timea-solid
temporarily deployed
to
ESS PodSpaces
April 14, 2023 16:47 — with 
GitHub Actions
Inactive
timea-solid
temporarily deployed
to
ESS PodSpaces
April 14, 2023 16:47 — with GitHub Actions
Inactive
timea-solid
marked this pull request as draft
April 14, 2023 17:53
timea-solid
temporarily deployed
to
ESS PodSpaces
April 17, 2023 13:33 — with GitHub Actions
Inactive
timea-solid
temporarily deployed
to
ESS PodSpaces
April 17, 2023 13:33 — with GitHub Actions
Inactive
timea-solid
temporarily deployed
to
ESS PodSpaces
April 17, 2023 14:06 — with GitHub Actions
Inactive
timea-solid
temporarily deployed
to
ESS PodSpaces
April 17, 2023 14:06 — with GitHub Actions
Inactive
timea-solid
marked this pull request as ready for review
April 17, 2023 14:07
timea-solid
temporarily deployed
to
ESS PodSpaces
April 21, 2023 07:58 — with GitHub Actions
Inactive
timea-solid
temporarily deployed
to
ESS PodSpaces
April 21, 2023 07:58 — with GitHub Actions
Inactive
acoburn
reviewed
Apr 21, 2023
acoburn
left a comment
Contributor
There was a problem hiding this comment.
Might be worth discussing this in more detail
| * @param request an AccessRequest | ||
| * @return the next stage of completion containing the resulting credential | ||
| */ | ||
| public CompletionStage<AccessGrant> approveAccessRequest(final AccessRequest request) { |
Contributor
There was a problem hiding this comment.
I would call this issueAccessGrant
ContributorAuthor
There was a problem hiding this comment.
issueAccessRequest name is to specify it is a request and not the actual issue call.
I call it better issueGrantRequest
| /** | ||
| * An Access Grant issue request. | ||
| */ | ||
| public class AccessRequest { |
Contributor
There was a problem hiding this comment.
I would have this extend or implement an AccessCredential type
| return this.data; | ||
| } | ||
| public AccessRequest(final Map<String, Object> data) { |
Contributor
There was a problem hiding this comment.
I would make this more structured. A map is too general
timea-solid
commented
May 9, 2023
ContributorAuthor
I know we discussed removing the extra class but that would require me to pass Map<String, Object> around. Because of this, I try here to create more architecture. |
acoburn
commented
May 19, 2023
Contributor
Superseded by #461 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The names are at the moment taken form the JS library:
We can of course rethink the names.
The issueAccessRequest has a toCompletableFuture().join() now, not sure.