Skip to content

add ReactDOM and update .getDOMNode() to ReactDOM.findDOMNode instead#21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cracdev wants to merge 1 commit into
base:master
Choose a base branch
from
Open

add ReactDOM and update .getDOMNode() to ReactDOM.findDOMNode instead #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion example/example.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
var React = require('react')
var ReactDOM = require('react-dom')

var SelectBox = React.createFactory(require('../lib/select-box'))

var div = React.createElement.bind(null,'div')
Expand DownExpand Up@@ -56,4 +58,4 @@ var Example = React.createFactory(React.createClass({displayName: 'Example',
}
}))

React.render(Example(null), document.body)
ReactDOM.render(Example(null), document.querySelector('#main'))
1 change: 1 addition & 0 deletions example/index.html
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,6 +6,7 @@
<link rel="stylesheet" href="select-box.css" />
</head>
<body>
<div id="main"></div>
<script src="example.js"></script>
</body>
</html>
5 changes: 3 additions & 2 deletions lib/select-box.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
"use strict"

var React = require('react')
var ReactDOM = require('react-dom')

var div = React.createElement.bind(null, 'div')
var button = React.createElement.bind(null, 'button')
Expand DownExpand Up@@ -100,7 +101,7 @@ module.exports = React.createClass({displayName: 'exports',
} else {
this.updatePendingValue(val, cb) || this.props.onChange(val)
this.handleClose()
this.refs.button.getDOMNode().focus()
ReactDOM.findDOMNode(this.refs.button).focus();
}
}.bind(this)
},
Expand DownExpand Up@@ -140,7 +141,7 @@ module.exports = React.createClass({displayName: 'exports',
handleOpen: function (event) {
interceptEvent(event)
this.setState({open: true}, function () {
this.refs.menu.getDOMNode().focus()
ReactDOM.findDOMNode(this.refs.menu).focus();
})
},

Expand Down