fix: lint:changes command to only lint changed files by joyenjoyer · Pull Request #2665 · instructure/instructure-ui

joyenjoyer · 2026-07-29T11:21:56Z

Summary

Replace broken --since HEAD^ flag with git merge-base to properly target changed files
Pass changed files directly to oxlint instead of routing through workspace runner
Fixes lint:changes to skip unchanged portions of the codebase

Test Plan

pnpm run lint:changes now only lints files in the diff since merge-base

Fixes INSTUI-5090

github-actions · 2026-07-29T11:26:52Z

PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-08-31 10:29 UTC

github-actions · 2026-07-29T11:40:32Z

Visual regression report

Cypress suite: ✅ Passing

Visual diff:⚠️Changes detected.

Status	Count
Unchanged	95
Changed	1
New	0
Removed	0

Accessibility (axe): ✅ No violations.

📊 View full report — click a screenshot's ⚠ badge to see each violation boxed on the image, with the offending element named and contrast failures shown as color swatches.

Diff images (1)

table-canvas.png — 3338 pixels differ

_{Baselines come from the visual-baselines branch. They refresh on every merge to master. The Cypress suite line covers the a11y and console-error assertions — a ❌ there means the suite found real issues even if the visual diff is clean.}

balzss

this command breaks workflows without js/ts changes since oxlint exits with 1. ironically this very PR is a good example

joyenjoyer · 2026-08-12T12:57:34Z

 "test:browser-ui": "pnpm run playwright:install && vitest --project browser --browser.headless=false --ui",
 "lint": "pnpm -r --stream lint",
- "lint:changes": "git diff --name-only $(git merge-base HEAD origin/master)..HEAD | xargs -r oxlint --format=unix",
+ "lint:changes": "git diff --name-only $(git merge-base HEAD origin/master)..HEAD | { grep -E '\\.(js|jsx|ts|tsx|mjs|cjs)$' || true; } | xargs -r oxlint --format=unix",


@balzss
git diff: list files changed since branching from master
grep (+ || true): keep only lintable extensions; don't fail if none match
xargs -r oxlint: only run oxlint if files remain, so no-match no longer exits 123

balzss

Issue with the current solution:git diff --name-only also lists deleted files, and oxlint exits 1 (No files found to lint) when every path it gets no longer exists — so a PR whose only lintable change is a deletion (e.g. removing an obsolete test) will fail the lint job. The pre-commit hook won't catch it either, since lint-staged skips deleted files.

Suggested fix: add --diff-filter=ACMR to the git diff call so deleted paths never reach oxlint.

please note that the fix was suggested by claude and needs a double check

Replace the broken --since flag with proper merge-base diff logic. The command now gets files changed since merge-base with master and passes them directly to oxlint instead of routing through the workspace runner which would lint the entire codebase.

…anged Filter the changed-file list to lintable extensions before handing it to oxlint, so it's only invoked when there's actually something to lint.

balzss

looks good, i'll aprove but i'll also mention 2 nitpicks:

docs/contributing/contributing-getting-started.md:54 mentions this command linting since the last commit but actually it lints since branching off from master
maybe scripts like this could live in ui-scrips and only be referenced here for better readability

joyenjoyer · 2026-07-29T11:21:56Z

Summary

Replace broken --since HEAD^ flag with git merge-base to properly target changed files
Pass changed files directly to oxlint instead of routing through workspace runner
Fixes lint:changes to skip unchanged portions of the codebase

Test Plan

pnpm run lint:changes now only lints files in the diff since merge-base

Fixes INSTUI-5090

github-actions · 2026-07-29T11:26:52Z

PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-08-31 10:29 UTC

github-actions · 2026-07-29T11:40:32Z

Visual regression report

Cypress suite: ✅ Passing

Visual diff:⚠️Changes detected.

Status	Count
Unchanged	95
Changed	1
New	0
Removed	0

Accessibility (axe): ✅ No violations.

📊 View full report — click a screenshot's ⚠ badge to see each violation boxed on the image, with the offending element named and contrast failures shown as color swatches.

Diff images (1)

table-canvas.png — 3338 pixels differ

_{Baselines come from the visual-baselines branch. They refresh on every merge to master. The Cypress suite line covers the a11y and console-error assertions — a ❌ there means the suite found real issues even if the visual diff is clean.}

balzss

this command breaks workflows without js/ts changes since oxlint exits with 1. ironically this very PR is a good example

joyenjoyer · 2026-08-12T12:57:34Z

 "test:browser-ui": "pnpm run playwright:install && vitest --project browser --browser.headless=false --ui",
 "lint": "pnpm -r --stream lint",
- "lint:changes": "git diff --name-only $(git merge-base HEAD origin/master)..HEAD | xargs -r oxlint --format=unix",
+ "lint:changes": "git diff --name-only $(git merge-base HEAD origin/master)..HEAD | { grep -E '\\.(js|jsx|ts|tsx|mjs|cjs)$' || true; } | xargs -r oxlint --format=unix",


@balzss
git diff: list files changed since branching from master
grep (+ || true): keep only lintable extensions; don't fail if none match
xargs -r oxlint: only run oxlint if files remain, so no-match no longer exits 123

balzss

Issue with the current solution:git diff --name-only also lists deleted files, and oxlint exits 1 (No files found to lint) when every path it gets no longer exists — so a PR whose only lintable change is a deletion (e.g. removing an obsolete test) will fail the lint job. The pre-commit hook won't catch it either, since lint-staged skips deleted files.

Suggested fix: add --diff-filter=ACMR to the git diff call so deleted paths never reach oxlint.

please note that the fix was suggested by claude and needs a double check

Replace the broken --since flag with proper merge-base diff logic. The command now gets files changed since merge-base with master and passes them directly to oxlint instead of routing through the workspace runner which would lint the entire codebase.

…anged Filter the changed-file list to lintable extensions before handing it to oxlint, so it's only invoked when there's actually something to lint.

balzss

looks good, i'll aprove but i'll also mention 2 nitpicks:

docs/contributing/contributing-getting-started.md:54 mentions this command linting since the last commit but actually it lints since branching off from master
maybe scripts like this could live in ui-scrips and only be referenced here for better readability

joyenjoyer · 2026-07-29T11:21:56Z

Summary

Replace broken --since HEAD^ flag with git merge-base to properly target changed files
Pass changed files directly to oxlint instead of routing through workspace runner
Fixes lint:changes to skip unchanged portions of the codebase

Test Plan

pnpm run lint:changes now only lints files in the diff since merge-base

Fixes INSTUI-5090

github-actions · 2026-07-29T11:26:52Z

PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-08-31 10:29 UTC

github-actions · 2026-07-29T11:40:32Z

Visual regression report

Cypress suite: ✅ Passing

Visual diff:⚠️Changes detected.

Status	Count
Unchanged	95
Changed	1
New	0
Removed	0

Accessibility (axe): ✅ No violations.

📊 View full report — click a screenshot's ⚠ badge to see each violation boxed on the image, with the offending element named and contrast failures shown as color swatches.

Diff images (1)

table-canvas.png — 3338 pixels differ

_{Baselines come from the visual-baselines branch. They refresh on every merge to master. The Cypress suite line covers the a11y and console-error assertions — a ❌ there means the suite found real issues even if the visual diff is clean.}

balzss

this command breaks workflows without js/ts changes since oxlint exits with 1. ironically this very PR is a good example

joyenjoyer · 2026-08-12T12:57:34Z

 "test:browser-ui": "pnpm run playwright:install && vitest --project browser --browser.headless=false --ui",
 "lint": "pnpm -r --stream lint",
- "lint:changes": "git diff --name-only $(git merge-base HEAD origin/master)..HEAD | xargs -r oxlint --format=unix",
+ "lint:changes": "git diff --name-only $(git merge-base HEAD origin/master)..HEAD | { grep -E '\\.(js|jsx|ts|tsx|mjs|cjs)$' || true; } | xargs -r oxlint --format=unix",


@balzss
git diff: list files changed since branching from master
grep (+ || true): keep only lintable extensions; don't fail if none match
xargs -r oxlint: only run oxlint if files remain, so no-match no longer exits 123

balzss

Issue with the current solution:git diff --name-only also lists deleted files, and oxlint exits 1 (No files found to lint) when every path it gets no longer exists — so a PR whose only lintable change is a deletion (e.g. removing an obsolete test) will fail the lint job. The pre-commit hook won't catch it either, since lint-staged skips deleted files.

Suggested fix: add --diff-filter=ACMR to the git diff call so deleted paths never reach oxlint.

please note that the fix was suggested by claude and needs a double check

Replace the broken --since flag with proper merge-base diff logic. The command now gets files changed since merge-base with master and passes them directly to oxlint instead of routing through the workspace runner which would lint the entire codebase.

…anged Filter the changed-file list to lintable extensions before handing it to oxlint, so it's only invoked when there's actually something to lint.

balzss

looks good, i'll aprove but i'll also mention 2 nitpicks:

docs/contributing/contributing-getting-started.md:54 mentions this command linting since the last commit but actually it lints since branching off from master
maybe scripts like this could live in ui-scrips and only be referenced here for better readability

joyenjoyer · 2026-07-29T11:21:56Z

Summary

Replace broken --since HEAD^ flag with git merge-base to properly target changed files
Pass changed files directly to oxlint instead of routing through workspace runner
Fixes lint:changes to skip unchanged portions of the codebase

Test Plan

pnpm run lint:changes now only lints files in the diff since merge-base

Fixes INSTUI-5090

github-actions · 2026-07-29T11:26:52Z

PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-08-31 10:29 UTC

github-actions · 2026-07-29T11:40:32Z

Visual regression report

Cypress suite: ✅ Passing

Visual diff:⚠️Changes detected.

Status	Count
Unchanged	95
Changed	1
New	0
Removed	0

Accessibility (axe): ✅ No violations.

📊 View full report — click a screenshot's ⚠ badge to see each violation boxed on the image, with the offending element named and contrast failures shown as color swatches.

Diff images (1)

table-canvas.png — 3338 pixels differ

_{Baselines come from the visual-baselines branch. They refresh on every merge to master. The Cypress suite line covers the a11y and console-error assertions — a ❌ there means the suite found real issues even if the visual diff is clean.}

balzss

this command breaks workflows without js/ts changes since oxlint exits with 1. ironically this very PR is a good example

joyenjoyer · 2026-08-12T12:57:34Z

 "test:browser-ui": "pnpm run playwright:install && vitest --project browser --browser.headless=false --ui",
 "lint": "pnpm -r --stream lint",
- "lint:changes": "git diff --name-only $(git merge-base HEAD origin/master)..HEAD | xargs -r oxlint --format=unix",
+ "lint:changes": "git diff --name-only $(git merge-base HEAD origin/master)..HEAD | { grep -E '\\.(js|jsx|ts|tsx|mjs|cjs)$' || true; } | xargs -r oxlint --format=unix",


@balzss
git diff: list files changed since branching from master
grep (+ || true): keep only lintable extensions; don't fail if none match
xargs -r oxlint: only run oxlint if files remain, so no-match no longer exits 123

balzss

Issue with the current solution:git diff --name-only also lists deleted files, and oxlint exits 1 (No files found to lint) when every path it gets no longer exists — so a PR whose only lintable change is a deletion (e.g. removing an obsolete test) will fail the lint job. The pre-commit hook won't catch it either, since lint-staged skips deleted files.

Suggested fix: add --diff-filter=ACMR to the git diff call so deleted paths never reach oxlint.

please note that the fix was suggested by claude and needs a double check

Replace the broken --since flag with proper merge-base diff logic. The command now gets files changed since merge-base with master and passes them directly to oxlint instead of routing through the workspace runner which would lint the entire codebase.

…anged Filter the changed-file list to lintable extensions before handing it to oxlint, so it's only invoked when there's actually something to lint.

balzss

looks good, i'll aprove but i'll also mention 2 nitpicks:

docs/contributing/contributing-getting-started.md:54 mentions this command linting since the last commit but actually it lints since branching off from master
maybe scripts like this could live in ui-scrips and only be referenced here for better readability

joyenjoyer · 2026-07-29T11:21:56Z

Summary

Replace broken --since HEAD^ flag with git merge-base to properly target changed files
Pass changed files directly to oxlint instead of routing through workspace runner
Fixes lint:changes to skip unchanged portions of the codebase

Test Plan

pnpm run lint:changes now only lints files in the diff since merge-base

Fixes INSTUI-5090

github-actions · 2026-07-29T11:26:52Z

PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-08-31 10:29 UTC

github-actions · 2026-07-29T11:40:32Z

Visual regression report

Cypress suite: ✅ Passing

Visual diff:⚠️Changes detected.

Status	Count
Unchanged	95
Changed	1
New	0
Removed	0

Accessibility (axe): ✅ No violations.

📊 View full report — click a screenshot's ⚠ badge to see each violation boxed on the image, with the offending element named and contrast failures shown as color swatches.

Diff images (1)

table-canvas.png — 3338 pixels differ

_{Baselines come from the visual-baselines branch. They refresh on every merge to master. The Cypress suite line covers the a11y and console-error assertions — a ❌ there means the suite found real issues even if the visual diff is clean.}

balzss

this command breaks workflows without js/ts changes since oxlint exits with 1. ironically this very PR is a good example

joyenjoyer · 2026-08-12T12:57:34Z

 "test:browser-ui": "pnpm run playwright:install && vitest --project browser --browser.headless=false --ui",
 "lint": "pnpm -r --stream lint",
- "lint:changes": "git diff --name-only $(git merge-base HEAD origin/master)..HEAD | xargs -r oxlint --format=unix",
+ "lint:changes": "git diff --name-only $(git merge-base HEAD origin/master)..HEAD | { grep -E '\\.(js|jsx|ts|tsx|mjs|cjs)$' || true; } | xargs -r oxlint --format=unix",


@balzss
git diff: list files changed since branching from master
grep (+ || true): keep only lintable extensions; don't fail if none match
xargs -r oxlint: only run oxlint if files remain, so no-match no longer exits 123

balzss

Issue with the current solution:git diff --name-only also lists deleted files, and oxlint exits 1 (No files found to lint) when every path it gets no longer exists — so a PR whose only lintable change is a deletion (e.g. removing an obsolete test) will fail the lint job. The pre-commit hook won't catch it either, since lint-staged skips deleted files.

Suggested fix: add --diff-filter=ACMR to the git diff call so deleted paths never reach oxlint.

please note that the fix was suggested by claude and needs a double check

Replace the broken --since flag with proper merge-base diff logic. The command now gets files changed since merge-base with master and passes them directly to oxlint instead of routing through the workspace runner which would lint the entire codebase.

…anged Filter the changed-file list to lintable extensions before handing it to oxlint, so it's only invoked when there's actually something to lint.

balzss

looks good, i'll aprove but i'll also mention 2 nitpicks:

docs/contributing/contributing-getting-started.md:54 mentions this command linting since the last commit but actually it lints since branching off from master
maybe scripts like this could live in ui-scrips and only be referenced here for better readability

joyenjoyer · 2026-07-29T11:21:56Z

Summary

Replace broken --since HEAD^ flag with git merge-base to properly target changed files
Pass changed files directly to oxlint instead of routing through workspace runner
Fixes lint:changes to skip unchanged portions of the codebase

Test Plan

pnpm run lint:changes now only lints files in the diff since merge-base

Fixes INSTUI-5090

github-actions · 2026-07-29T11:26:52Z

PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-08-31 10:29 UTC

github-actions · 2026-07-29T11:40:32Z

Visual regression report

Cypress suite: ✅ Passing

Visual diff:⚠️Changes detected.

Status	Count
Unchanged	95
Changed	1
New	0
Removed	0

Accessibility (axe): ✅ No violations.

📊 View full report — click a screenshot's ⚠ badge to see each violation boxed on the image, with the offending element named and contrast failures shown as color swatches.

Diff images (1)

table-canvas.png — 3338 pixels differ

_{Baselines come from the visual-baselines branch. They refresh on every merge to master. The Cypress suite line covers the a11y and console-error assertions — a ❌ there means the suite found real issues even if the visual diff is clean.}

balzss

this command breaks workflows without js/ts changes since oxlint exits with 1. ironically this very PR is a good example

joyenjoyer · 2026-08-12T12:57:34Z

 "test:browser-ui": "pnpm run playwright:install && vitest --project browser --browser.headless=false --ui",
 "lint": "pnpm -r --stream lint",
- "lint:changes": "git diff --name-only $(git merge-base HEAD origin/master)..HEAD | xargs -r oxlint --format=unix",
+ "lint:changes": "git diff --name-only $(git merge-base HEAD origin/master)..HEAD | { grep -E '\\.(js|jsx|ts|tsx|mjs|cjs)$' || true; } | xargs -r oxlint --format=unix",


@balzss
git diff: list files changed since branching from master
grep (+ || true): keep only lintable extensions; don't fail if none match
xargs -r oxlint: only run oxlint if files remain, so no-match no longer exits 123

balzss

Issue with the current solution:git diff --name-only also lists deleted files, and oxlint exits 1 (No files found to lint) when every path it gets no longer exists — so a PR whose only lintable change is a deletion (e.g. removing an obsolete test) will fail the lint job. The pre-commit hook won't catch it either, since lint-staged skips deleted files.

Suggested fix: add --diff-filter=ACMR to the git diff call so deleted paths never reach oxlint.

please note that the fix was suggested by claude and needs a double check

Replace the broken --since flag with proper merge-base diff logic. The command now gets files changed since merge-base with master and passes them directly to oxlint instead of routing through the workspace runner which would lint the entire codebase.

…anged Filter the changed-file list to lintable extensions before handing it to oxlint, so it's only invoked when there's actually something to lint.

balzss

looks good, i'll aprove but i'll also mention 2 nitpicks:

docs/contributing/contributing-getting-started.md:54 mentions this command linting since the last commit but actually it lints since branching off from master
maybe scripts like this could live in ui-scrips and only be referenced here for better readability

joyenjoyer · 2026-07-29T11:21:56Z

Summary

Replace broken --since HEAD^ flag with git merge-base to properly target changed files
Pass changed files directly to oxlint instead of routing through workspace runner
Fixes lint:changes to skip unchanged portions of the codebase

Test Plan

pnpm run lint:changes now only lints files in the diff since merge-base

Fixes INSTUI-5090

github-actions · 2026-07-29T11:26:52Z

PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-08-31 10:29 UTC

github-actions · 2026-07-29T11:40:32Z

Visual regression report

Cypress suite: ✅ Passing

Visual diff:⚠️Changes detected.

Status	Count
Unchanged	95
Changed	1
New	0
Removed	0

Accessibility (axe): ✅ No violations.

📊 View full report — click a screenshot's ⚠ badge to see each violation boxed on the image, with the offending element named and contrast failures shown as color swatches.

Diff images (1)

table-canvas.png — 3338 pixels differ

_{Baselines come from the visual-baselines branch. They refresh on every merge to master. The Cypress suite line covers the a11y and console-error assertions — a ❌ there means the suite found real issues even if the visual diff is clean.}

balzss

this command breaks workflows without js/ts changes since oxlint exits with 1. ironically this very PR is a good example

joyenjoyer · 2026-08-12T12:57:34Z

 "test:browser-ui": "pnpm run playwright:install && vitest --project browser --browser.headless=false --ui",
 "lint": "pnpm -r --stream lint",
- "lint:changes": "git diff --name-only $(git merge-base HEAD origin/master)..HEAD | xargs -r oxlint --format=unix",
+ "lint:changes": "git diff --name-only $(git merge-base HEAD origin/master)..HEAD | { grep -E '\\.(js|jsx|ts|tsx|mjs|cjs)$' || true; } | xargs -r oxlint --format=unix",


@balzss
git diff: list files changed since branching from master
grep (+ || true): keep only lintable extensions; don't fail if none match
xargs -r oxlint: only run oxlint if files remain, so no-match no longer exits 123

balzss

Issue with the current solution:git diff --name-only also lists deleted files, and oxlint exits 1 (No files found to lint) when every path it gets no longer exists — so a PR whose only lintable change is a deletion (e.g. removing an obsolete test) will fail the lint job. The pre-commit hook won't catch it either, since lint-staged skips deleted files.

Suggested fix: add --diff-filter=ACMR to the git diff call so deleted paths never reach oxlint.

please note that the fix was suggested by claude and needs a double check

Replace the broken --since flag with proper merge-base diff logic. The command now gets files changed since merge-base with master and passes them directly to oxlint instead of routing through the workspace runner which would lint the entire codebase.

…anged Filter the changed-file list to lintable extensions before handing it to oxlint, so it's only invoked when there's actually something to lint.

balzss

looks good, i'll aprove but i'll also mention 2 nitpicks:

docs/contributing/contributing-getting-started.md:54 mentions this command linting since the last commit but actually it lints since branching off from master
maybe scripts like this could live in ui-scrips and only be referenced here for better readability

joyenjoyer · 2026-07-29T11:21:56Z

Summary

Replace broken --since HEAD^ flag with git merge-base to properly target changed files
Pass changed files directly to oxlint instead of routing through workspace runner
Fixes lint:changes to skip unchanged portions of the codebase

Test Plan

pnpm run lint:changes now only lints files in the diff since merge-base

Fixes INSTUI-5090

github-actions · 2026-07-29T11:26:52Z

PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-08-31 10:29 UTC

github-actions · 2026-07-29T11:40:32Z

Visual regression report

Cypress suite: ✅ Passing

Visual diff:⚠️Changes detected.

Status	Count
Unchanged	95
Changed	1
New	0
Removed	0

Accessibility (axe): ✅ No violations.

📊 View full report — click a screenshot's ⚠ badge to see each violation boxed on the image, with the offending element named and contrast failures shown as color swatches.

Diff images (1)

table-canvas.png — 3338 pixels differ

_{Baselines come from the visual-baselines branch. They refresh on every merge to master. The Cypress suite line covers the a11y and console-error assertions — a ❌ there means the suite found real issues even if the visual diff is clean.}

balzss

this command breaks workflows without js/ts changes since oxlint exits with 1. ironically this very PR is a good example

joyenjoyer · 2026-08-12T12:57:34Z

 "test:browser-ui": "pnpm run playwright:install && vitest --project browser --browser.headless=false --ui",
 "lint": "pnpm -r --stream lint",
- "lint:changes": "git diff --name-only $(git merge-base HEAD origin/master)..HEAD | xargs -r oxlint --format=unix",
+ "lint:changes": "git diff --name-only $(git merge-base HEAD origin/master)..HEAD | { grep -E '\\.(js|jsx|ts|tsx|mjs|cjs)$' || true; } | xargs -r oxlint --format=unix",


@balzss
git diff: list files changed since branching from master
grep (+ || true): keep only lintable extensions; don't fail if none match
xargs -r oxlint: only run oxlint if files remain, so no-match no longer exits 123

balzss

Issue with the current solution:git diff --name-only also lists deleted files, and oxlint exits 1 (No files found to lint) when every path it gets no longer exists — so a PR whose only lintable change is a deletion (e.g. removing an obsolete test) will fail the lint job. The pre-commit hook won't catch it either, since lint-staged skips deleted files.

Suggested fix: add --diff-filter=ACMR to the git diff call so deleted paths never reach oxlint.

please note that the fix was suggested by claude and needs a double check

Replace the broken --since flag with proper merge-base diff logic. The command now gets files changed since merge-base with master and passes them directly to oxlint instead of routing through the workspace runner which would lint the entire codebase.

…anged Filter the changed-file list to lintable extensions before handing it to oxlint, so it's only invoked when there's actually something to lint.

balzss

looks good, i'll aprove but i'll also mention 2 nitpicks:

docs/contributing/contributing-getting-started.md:54 mentions this command linting since the last commit but actually it lints since branching off from master
maybe scripts like this could live in ui-scrips and only be referenced here for better readability

joyenjoyer changed the base branch from master to instui-5035-oxlint-migrationJuly 29, 2026 11:24

joyenjoyer self-assigned this Jul 29, 2026

joyenjoyer requested a review from balzss July 29, 2026 11:24

joyenjoyer force-pushed the lint_changes_fix branch 2 times, most recently from f69eb89 to b60b30aCompare July 29, 2026 11:34

github-actionsBot pushed a commit that referenced this pull request Jul 29, 2026
visual-regression: PR#2665(133553c)133553c
68baaee

github-actionsBot pushed a commit that referenced this pull request Jul 29, 2026
visual-regression: PR#2665(fa7a815)fa7a815
7d884af

Base automatically changed from instui-5035-oxlint-migration to masterAugust 3, 2026 11:21

joyenjoyer changed the base branch from master to fix-regression-a11y-screenshot-decoupleAugust 3, 2026 11:23

joyenjoyer changed the base branch from fix-regression-a11y-screenshot-decouple to masterAugust 3, 2026 11:23

joyenjoyer force-pushed the lint_changes_fix branch from b60b30a to e5b15d7Compare August 3, 2026 11:25

github-actionsBot pushed a commit that referenced this pull request Aug 3, 2026
visual-regression: PR#2665(a00d737)a00d737
8d134e4

balzss requested changes Aug 12, 2026
View reviewed changes

joyenjoyer commented Aug 12, 2026
View reviewed changes

joyenjoyer requested a review from balzss August 12, 2026 13:03

github-actionsBot pushed a commit that referenced this pull request Aug 12, 2026
visual-regression: PR#2665(e05c74e)e05c74e
f3b03d8

balzss requested changes Aug 19, 2026
View reviewed changes

joyenjoyer force-pushed the lint_changes_fix branch from 01cf0ce to f72ced0Compare August 26, 2026 12:23

joyenjoyer requested a review from balzss August 26, 2026 12:23

joyenjoyer added 2 commits August 26, 2026 14:27

fix: skip oxlint invocation in lint:changes when no lintable files ch…
8032954
…anged Filter the changed-file list to lintable extensions before handing it to oxlint, so it's only invoked when there's actually something to lint.

joyenjoyer force-pushed the lint_changes_fix branch from f72ced0 to 8032954Compare August 26, 2026 12:27

github-actionsBot pushed a commit that referenced this pull request Aug 26, 2026
visual-regression: PR#2665(171a724)171a724
e4d95e0

github-actionsBot pushed a commit that referenced this pull request Aug 26, 2026
visual-regression: PR#2665(8dddb88)8dddb88
42e35bd

balzss approved these changes Aug 26, 2026
View reviewed changes

joyenjoyer requested a review from git-nandor August 27, 2026 14:09

git-nandor approved these changes Aug 28, 2026
View reviewed changes

joyenjoyer merged commit d4a507b into masterAug 31, 2026
10 of 11 checks passed

joyenjoyer deleted the lint_changes_fix branch August 31, 2026 10:29

github-actionsBot added a commit that referenced this pull request Aug 31, 2026
visual-regression: remove report for closed PR#2665
e60c2ab