Uh oh!
There was an error while loading. Please reload this page.
Meta rebase - #3
Closed
guptask wants to merge 2159 commits into
Closed
Conversation
Summary: GitHub commits: facebook@35c9317facebook/fb303@ff82ca2facebook/fbthrift@fd12520facebook/proxygen@19e6422facebook/watchman@13b64dbfacebookexperimental/rust-shed@bcbcd78 Reviewed By: jurajh-fb fbshipit-source-id: 1cae62ca1816999755fa7d02ade5acb0d7d6a1c2
Summary: GitHub commits: facebook@2d00d87facebook/fb303@64c9ab5facebook/fbthrift@4d10325facebook/watchman@e0d358efacebookexperimental/rust-shed@8dd991dfacebookincubator/velox@879dbcbpytorch/FBGEMM@49061a2 Reviewed By: jurajh-fb fbshipit-source-id: 4079f877b1f8824d11f1b38e426d902d82032d64
Summary: GitHub commits: facebook/fbthrift@2084e71facebookresearch/FLSim@25dcc15 Reviewed By: jurajh-fb fbshipit-source-id: 633ebba055ee849f612624dfdb4586e102f6c5e0
Summary: GitHub commits: facebook@9754496facebook/fb303@c90b698facebook/fbthrift@09c7898facebook/watchman@59d2099facebookexperimental/rust-shed@739451c Reviewed By: jurajh-fb fbshipit-source-id: f27967de0574c05e7a14443a058b77222d51a015
Summary: GitHub commits: facebook/fbthrift@4816073 Reviewed By: jurajh-fb fbshipit-source-id: 98a25f03da94d1a493dc3164ef873f4a7a6c4e7f
Summary: GitHub commits: facebook/fbthrift@f090926 Reviewed By: jurajh-fb fbshipit-source-id: 7d3458299e95ab7202eeb336fbaa8861f763f477
Summary: GitHub commits: facebook/fbthrift@29f5be1 Reviewed By: jurajh-fb fbshipit-source-id: 681ea59613c4a5f67b88cdefcef0b4992f64ecdd
Summary: - `ItemHandle` -> `WriteHandle` codemod in external use cases - Remove `ItemHandle` from cachelib codebase Reviewed By: therealgymmy Differential Revision: D37500348 fbshipit-source-id: 4aaf5bed9b1472064770e8845e2bdbd19af230a4
Summary: GitHub commits: facebook@6fde167facebook/fb303@75420d5facebook/fbthrift@c3f7287facebook/folly@6198adffacebook/litho@f9c68f0facebook/proxygen@82d1cc3facebook/rocksdb@e637470facebook/wangle@feb8186facebook/watchman@8d674a1facebookexperimental/edencommon@7b891aefacebookexperimental/rust-shed@450d3f3facebookincubator/Eigen-FBPlugins@a04ae2cfacebookincubator/fizz@2c581c3facebookincubator/katran@6c1b037facebook/mvfst@c3a61c5facebookincubator/velox@c76a9d2facebookresearch/beanmachine@834f3a7facebookresearch/multimodal@1c4fa80pytorch/FBGEMM@a6f5488meta-pytorch/multipy@5af38eb Reviewed By: wittgenst fbshipit-source-id: 2ad5d5d2f8153b308824a361b41c3d003b2f030d
Summary: GitHub commits: facebook@b55cb24facebook/fb303@f579f33facebook/fbthrift@2e1eb49facebook/proxygen@117513afacebook/rocksdb@2fc6df3facebook/wangle@f238460facebook/watchman@19fb934facebookexperimental/edencommon@a28957cfacebookexperimental/rust-shed@bd5a53dfacebookincubator/fizz@fa63302facebookincubator/katran@d1f0274facebook/mvfst@0e05cc8facebookincubator/velox@9ea9ba4facebookresearch/beanmachine@463c58c Reviewed By: wittgenst fbshipit-source-id: fd0f90bc6848a85848bc0d35909a1771f4888845
Summary: GitHub commits: facebook@ad8e718facebook/fb303@c5c5c73facebook/fbthrift@b7332dafacebook/proxygen@d41b032facebook/rocksdb@84e9b6efacebook/wangle@634f3ddfacebook/watchman@7404ba0facebookexperimental/rust-shed@3847584facebookincubator/katran@00bc4eefacebook/mvfst@4985673facebookresearch/multimodal@52c58ed Reviewed By: wittgenst fbshipit-source-id: b7c04db11d2cf98f76fcd6e940fadebdee3e79cc
Summary: GitHub commits: facebook@8fe6332facebook/fb303@31df3c7facebook/fbthrift@dfc34b1facebook/proxygen@3c36738facebook/watchman@06bb569facebookexperimental/rust-shed@bcf941epytorch/FBGEMM@60a5c2b Reviewed By: wittgenst fbshipit-source-id: 086b16d3d7411255bda0145f97ffa268ac046cd3
Summary: GitHub commits: facebook/fbthrift@8ce919e Reviewed By: wittgenst fbshipit-source-id: 830dd79a01a7084fa6f37ec71b2b8113dd3f64eb
Summary: GitHub commits: facebook/folly@bd3e0f7 Reviewed By: wittgenst fbshipit-source-id: 789ee0df03bc957ab274a27d859c8d3cd7a6e37c
Summary: GitHub commits: facebook@371611afacebook/fb303@240fddcfacebook/fbthrift@3d0e4ecfacebook/proxygen@dfcffe9facebook/wangle@3ece116facebook/watchman@b9da36dfacebookexperimental/edencommon@63199b5facebookincubator/fizz@feef1fbfacebookincubator/katran@1526abbfacebook/mvfst@ea0e50efacebookincubator/velox@1d66d46 Reviewed By: wittgenst fbshipit-source-id: 9d9714b7e1514b77947009c9d66b940e4d0a929d
Summary: GitHub commits: facebook@84d9cbbfacebook/fb303@5e1c47afacebook/fbthrift@b309babfacebook/proxygen@1205190facebook/wangle@a4f3a14facebook/watchman@34f0429facebookexperimental/rust-shed@8087bb5facebookincubator/katran@f82567bfacebook/mvfst@bdd8526pytorch/FBGEMM@308dd51 Reviewed By: wittgenst fbshipit-source-id: aa40779e080c60d2b0c3cbc2f0877e2a8940695e
Summary: GitHub commits: facebook@3826474facebook/fb303@d5e6e66facebook/fbthrift@8d051f0facebook/litho@80346a6facebook/proxygen@94863a7facebook/watchman@0c0f88ffacebookexperimental/rust-shed@163e4a1 Reviewed By: wittgenst fbshipit-source-id: fea16b41458db53a94cce907d91fa67c9400f40f
Summary: GitHub commits: facebook/fbthrift@a4fdb4a Reviewed By: wittgenst fbshipit-source-id: f2511ee94b10175cdb76934e663aaad372bb4c13
Summary: GitHub commits: facebook@1b1efaffacebook/fb303@4772c04facebook/fbthrift@ba4c6eafacebook/watchman@19bd6b4facebookexperimental/rust-shed@ded0566facebookresearch/FLSim@f552c50 Reviewed By: wittgenst fbshipit-source-id: 80c528702d5230d5e6c7393f5f7fcc5c065487b4
Summary: GitHub commits: facebook/fbthrift@93deaa2facebook/litho@2ad905dfacebook/watchman@063d421facebookincubator/velox@0f34e2e Reviewed By: wittgenst fbshipit-source-id: 1f8193cbb4cc8ee7e0781ccc583e2a0c41e508fa
Summary: GitHub commits: facebook/folly@6e11b1efacebookresearch/beanmachine@8bdfb73 Reviewed By: wittgenst fbshipit-source-id: fe32c2aa0dea86fdc52906e03784f0a18cedb03e
Summary: GitHub commits: facebook@0ea6364facebook/fb303@5590cabfacebook/fbthrift@e9f06b8facebook/proxygen@2649426facebook/rocksdb@3134471facebook/wangle@18d96b5facebook/watchman@390c95ffacebookexperimental/edencommon@bb0569bfacebookexperimental/rust-shed@34d8ec0facebookincubator/fizz@7a5a58cfacebookincubator/katran@37aaf3cfacebook/mvfst@b01a8f5facebookincubator/velox@be7ca7b Reviewed By: wittgenst fbshipit-source-id: 73248af094ccbd63418d0cd4887116076ccee81c
Summary: GitHub commits: facebook@eb09228facebook/fb303@e08babafacebook/fbthrift@7c1e720facebook/folly@3b7c54bfacebook/proxygen@e8ed3cafacebook/wangle@0e05dc5facebook/watchman@413e0d2facebookexperimental/edencommon@8ba1ed9facebookexperimental/rust-shed@8867360facebookincubator/katran@64a3e79facebook/mvfst@fa7299afacebookincubator/velox@2bcce7ffacebookresearch/FLSim@101ce58facebookresearch/multimodal@d710d46pytorch/FBGEMM@949420c Reviewed By: wittgenst fbshipit-source-id: 297d3dbc2e777e636440f598252b3f445292d668
Summary: GitHub commits: facebook@e5ce298facebook/fb303@51c5fecfacebook/fbthrift@ffa95eafacebook/proxygen@3a7ff11facebook/wangle@5605ef6facebook/watchman@ad48e7efacebookexperimental/edencommon@03096cbfacebookexperimental/rust-shed@6048fabfacebookincubator/fizz@13cdf6efacebookincubator/katran@bd20ac8facebook/mvfst@4d56a82facebookincubator/velox@dacfce2 Reviewed By: wittgenst fbshipit-source-id: 8288bb093f451b36913c6304e1e06b4fb2ba4ce8
Summary: GitHub commits: facebook@daf2f98facebook/fb303@ffb4c6efacebook/fbthrift@627baedfacebook/folly@b756ce7facebook/proxygen@10a744dfacebook/wangle@0b9cc53facebook/watchman@28a2cd8facebookexperimental/rust-shed@6323447facebookincubator/fizz@8af5c40facebookincubator/katran@505e2e2facebook/mvfst@a8c0974facebookincubator/velox@517427ffacebookresearch/beanmachine@e2e9ca3 Reviewed By: wittgenst fbshipit-source-id: 552b6c319385063f5e3b8f58b8f7d1cee4cc2665
Summary: GitHub commits: facebook@02bcd69facebook/fb303@0564c49facebook/fbthrift@7607fe0facebook/folly@40e95b6facebook/proxygen@ce56514facebook/wangle@d7a58ebfacebook/watchman@f142258facebookexperimental/edencommon@ec543dafacebookexperimental/rust-shed@8a083b9facebookincubator/fizz@90ffa60facebookincubator/katran@ed60cc1facebook/mvfst@f157e50facebookincubator/velox@d0fdadcfacebookresearch/multimodal@e890867 Reviewed By: wittgenst fbshipit-source-id: 60f2be957e6d952376335dfef1384989dd392be6
Summary: GitHub commits: facebook@af66133facebook/fb303@82e2962facebook/fbthrift@3ec58bdfacebook/folly@3d6e679facebook/proxygen@485be58facebook/squangle@43c8644facebook/wangle@ff3dc58facebook/watchman@dd15e74facebookexperimental/edencommon@cdaa6a4facebookexperimental/rust-shed@9c585aafacebookincubator/fizz@c06e209facebookincubator/katran@de93524facebook/mvfst@83755a5facebookincubator/velox@5a9075e Reviewed By: wittgenst fbshipit-source-id: f520b2425bb5979f99f189a85d869611268d38c6
Summary: GitHub commits: facebook@1653d55facebook/fb303@e515de3facebook/fbthrift@3e2bbfafacebook/folly@df26892facebook/proxygen@dd26cd8facebook/rocksdb@9d7de65facebook/wangle@f84c916facebook/watchman@d88f0bdfacebookexperimental/edencommon@785c9fafacebookexperimental/rust-shed@6eca381facebookincubator/fizz@813f959facebookincubator/katran@fae921cfacebook/mvfst@8677d5dfacebookincubator/velox@eebb37a Reviewed By: wittgenst fbshipit-source-id: 9efc1f562eaae2094b447999022a67c7f7462088
Summary: GitHub commits: facebook@ee6a029facebook/fb303@29d7d24facebook/fbthrift@a8652e8facebook/proxygen@dad8400facebook/wangle@091189ffacebook/watchman@1424672facebookexperimental/edencommon@d45c7acfacebookexperimental/rust-shed@b1498a8facebookincubator/fizz@1be0c95facebookincubator/katran@57f43d6facebook/mvfst@8cd45dbfacebookincubator/velox@20fafbffacebookresearch/beanmachine@6edb227 Reviewed By: wittgenst fbshipit-source-id: 7dbd79942c9ae98dafd74d5425c55186035f28b6
Summary: GitHub commits: facebook@45410defacebook/fb303@67fa3c4facebook/fbthrift@cade15efacebook/proxygen@a751494facebook/wangle@ca86d75facebook/watchman@df824c0facebookexperimental/rust-shed@8d44cc8facebookincubator/katran@b275fd3facebook/mvfst@d4f7cab Reviewed By: wittgenst fbshipit-source-id: 4b12b72db586107f0a1f8bdff9c6b77aeb0518a2
Without this fix removeCb called even in case when Item is moved between tiers.
It fails because CentOS is EOL. We might want to consider using CentOS Streams but for now, just remove it. Right now, we rely on build-cachelib-centos workflow anyway.
Disabled test suite allocator-test-AllocatorTypeTest to skip sporadically failing tests.
Compensation results in ratios being different than originially specified.
Return a sum of sizes of each tier instead of just 1st tier's size.
Compilation of some of the tests was failing with: "undefined reference to `facebook::cachelib::test_util::getRandomAsciiStr[abi:cxx11](unsigned int)'" Fix this by linking those tests with common/TestUtils.cpp Also, for some reason specyfing sources as in add_library(common_test_support INTERFACE [sources...]) did not work. Using target_sources works fine.
Centos8 is EOL
The issue happened when ReadHandleImpl ctor needs to destroy waitContext_ because addWaitContextForMovingItem() returns false. So before destroying waitContext_ we are calling discard method to notify ~ItemWaitContext() that Item is ready.
Do not use shallow clone to make sure Docker rebuild logic works correctly.
Get tier id of item before calling any function on allocator (which needs the tierID).
Remove the item from mmContainer and drop the lock before attempting eviction. Use moving bit for synchronization in findEviction moving bit is used to give exclusive right to evict the item to a particular thread. Originially, there was an assumption that whoever marked the item as moving will try to free it until he succeeds. Since we don't want to do that in findEviction (potentially can take a long time) we need to make sure that unmarking is safe. This patch checks the flags after unmarking (atomically) and if ref is zero it also recyles the item. This is needed as there might be some concurrent thread releasing the item (and decrementing ref count). If moving bit is set, that thread would not free the memory back to allocator, resulting in memory leak on unmarkMoving().
The main purpose of this patch is to better simulate workloads in cachebench. Setting touchValue to true allows to see performance impact of using different mediums for memory cache.
* #75: Use actual tier sizes (rounded down to slab size and decreased by header size) when creating new memory pools * Added getPoolSize method to calculate combined pool size for all tiers; added pool size validation to tests * Explicitly specified type for totalCacheSize to avoid overflow * Minor test change * Reworked tests * Minor change * Deleted redundant tests * Deleted unused constant * First set of changes to cache configuration API to enable multi-tier caches (facebook#138) Summary: These changes introduce per-tier cache configuration required to implement features discussed here: facebook#102. These specific changes enable single DRAM tier configs only which are compatible with the current version of cachelib. Configuration API will be expanded as multi-tier changes in other parts of the library are introduced. Pull Request resolved: facebook#138 Reviewed By: therealgymmy Differential Revision: D36189766 Pulled By: jiayuebao fbshipit-source-id: 947aa0cd800ea6accffc1b7b6b0c9693aa7fc0a5 Co-authored-by: Victoria McGrath <victoria.mcgrath@intel.com>
Hot queue iterator for 2Q. Will start at Hot queue and move to Warm queue if hot queue is exhausted. Useful for promotion semantics if using 2Q replacement. rebased on to develop and added some tests.
vinser52 pushed a commit
that referenced
this pull request
Sep 12, 2022
Summary: AdRanker ASAN canary flagged a possible UBSan violation. ## Error Failed Run: https://fburl.com/servicelab/apytosry ``` #0 0x562e3adb59bc in facebook::cachelib::objcache2::ObjectCacheSizeController<facebook::cachelib::CacheAllocator<facebook::cachelib::LruCacheTrait> >::work() buck-out/v2/gen/fbcode/47d914adeee3d982/cachelib/experimental/objcache2/__object-cache__/headers/cachelib/experimental/objcache2/ObjectCacheSizeController-inl.h #1 0x562de7610f78 in facebook::cachelib::PeriodicWorker::loop() fbcode/cachelib/common/PeriodicWorker.cpp:55 #2 0x7f7632c524e4 in execute_native_thread_routine /home/engshare/third-party2/libgcc/11.x/src/gcc-11.x/x86_64-facebook-linux/libstdc++-v3/src/c++11/../../../.././libstdc++-v3/src/c++11/thread.cc:82:18 #3 0x7f7632f6ec0e in start_thread /home/engshare/third-party2/glibc/2.34/src/glibc-2.34/nptl/pthread_create.c:434:8 #4 0x7f76330011db in clone3 /home/engshare/third-party2/glibc/2.34/src/glibc-2.34/misc/../sysdeps/unix/sysv/linux/x86_64/clone3.S:81 UndefinedBehaviorSanitizer: integer-divide-by-zero buck-out/v2/gen/fbcode/47d914adeee3d982/cachelib/experimental/objcache2/__object-cache__/headers/cachelib/experimental/objcache2/ObjectCacheSizeController-inl.h:33:40 in ``` Reviewed By: jiayuebao Differential Revision: D39024188 fbshipit-source-id: 64ad644c360565e638fa3ca74616a315038382ab
byrnedj pushed a commit
that referenced
this pull request
Jul 23, 2023
Publish changes from innersouce
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.