Uh oh!
There was an error while loading. Please reload this page.
add device information query/set interface - #503
Conversation
Uh oh!
There was an error while loading. Please reload this page.
| /** | ||
| * Query all attributes for a display handle | ||
| * The caller must provide an "attrib_list" array, the num_attibs should be set. | ||
| * if the The actual number of attributes < *num_attibs, the actual number of |
There was a problem hiding this comment.
fix text: "if the The". Should be: "If the". Mind capital I.
| * Query all attributes for a display handle | ||
| * The caller must provide an "attrib_list" array, the num_attibs should be set. | ||
| * if the The actual number of attributes < *num_attibs, the actual number of | ||
| * attributes will be returned in *num_attibs. if the *num_attibs < actual number |
| * unsupported. | ||
| */ | ||
| VAStatus vaQueryDeviceAttributes( |
There was a problem hiding this comment.
Should this be named Query or Get?
| /** | ||
| * Set Device configuration by this function, only when the device attribues is writable | ||
| * if APP want to use this function to set device configuration, this function must be |
There was a problem hiding this comment.
if APP want - is that a new sentence? add . and capitalize I.
| /** | ||
| * Set Device configuration by this function, only when the device attribues is writable | ||
| * if APP want to use this function to set device configuration, this function must be | ||
| * called after vaInitialize and before any other VAAPI function. if this function is called |
this interface is used to detect device information device information may include: memory locations, memory regions, deviceIDs etc. it is common attributes between vaContext. query interface: this function should be called after vaInitialize set interface: this function should be called after vaInitialize and before any other VAAPI functions, such as vaCreateSurfaces, etc. Signed-off-by: Carl Zhang <carl.zhang@intel.com>
| VAStatus vaSetDeviceAttributes( | ||
| VADisplay dpy, | ||
| VADeviceAttrib *attrib_list, |
There was a problem hiding this comment.
I notice that we already have vaGetDisplayAttributes/vaSetDisplayAttributes to control the
attributes of display. I think we can extend that API, no need to introduce another "Device"
concept.
There was a problem hiding this comment.
Initial concept for this API was slightly different, in particular consideration was to have attribs settable before vaInitialize. In this sense old API did not work for us... But then concept has changed we forgot to evaluate the new API vs. existing one.
@XinfengZhang : indeed, 2 sets of APIs start to look weird. Should we converge and just declare couple new display attributes?
There was a problem hiding this comment.
I wonder whether display attributes is suitable , because current display attributes seems just related with "Display" not adaptor
There was a problem hiding this comment.
I think yes, considering that adaptor/display is kind of merged thing in libva, and I would say even on Linux device exposure level (since we can use /dev/dri/cardN for display and encoding). So, having all attributes together seems ok to me - they just configure different aspects of the same entity.
| /** \brief current region index read - write | ||
| * vaQueryDeviceAttibutes , it will return pre-assigned memory region. | ||
| * vaSetDeviceAttributes, it is used indicate which memory region is selected*/ | ||
| uint32_t current_memory_region : 4; |
There was a problem hiding this comment.
Does these "regions" represent the tile of one GPU node?
this interface is used to detect device information
device information may include:
memory locations, memory regions, deviceIDs etc.
it is common attributes between vaContext.
query interface:
this function should be called after vaInitialize
set interface:
this function should be called after vaInitialize
and before any other VAAPI functions, such as vaCreateSurfaces, etc.
Signed-off-by: Carl Zhang carl.zhang@intel.com