Uh oh!
There was an error while loading. Please reload this page.
Add new error code to indicate the reset happended in the driver. - #714
Conversation
347520e to
e04fe6dComparepengxin99
commented
Jun 5, 2023
Hi, @XinfengZhang@Jexu, could you pls help to review this PR? |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
d7d0421 to
f18f2d5Compare| * After the applications get VA_STATUS_HW_BUSY or VA_STATUS_SUCCESSFULL from vaSyncSurface(), | ||
| * it still can call vaQuerySurfaceError to find out further details to know if has real hw reset | ||
| * happened on this surface since umd and kmd could recover the context from reset with success in sometimes. | ||
| * VA_STATUS_HW_BUSY or VA_STATUS_SUCCESSFULL also could be passed in as "error_status". |
There was a problem hiding this comment.
if there are one reset, and after re-run a while, there are another reset. how to know it?
each frame I need call it, first frame it is VADecodeReset, next frames it is invalid, then VADecodeReset again
There was a problem hiding this comment.
If user wants to know all the reset frames, then user needs to call vaQuerySurfaceError() for every frame and recode the reset information.
If user don't care about the reset, he can just call vaQuerySurfaceError() when get error from syncSurface().
XinfengZhang
left a comment
There was a problem hiding this comment.
LGTM, even "success" is treated as "error code" , it looks a little tricky.
Use VADecodeReset to indeicate media reset/engine reset have happended in the driver, user can use vaQuerySurfaceError() to get the detail info to do some customized work. Signed-off-by: Pengxin, Yuan <pengxin.yuan@intel.com>
f18f2d5 to
dcf353cCompare
Use VA_STATUS_ERROR_RESET to indeicate media reset/engine reset have happended in the driver, user can use vaQuerySurfaceError() to get the detail info to do some customized work.