Uh oh!
There was an error while loading. Please reload this page.
va: Fix -Wl,--version-script check with LLD 17 - #732
Open
vimproved wants to merge 1 commit into
Open
Conversation
vimproved added a commit
to vimproved/gentoo
that referenced
this pull request
Jul 20, 2023
Upstream PR: intel/libva#732 In the upcoming LLD 17 (and previously in LLD 16.0.0, but reverted in 16.0.1), --no-undefined-version is becoming the default behavior. This causes the configure check for --version-scripts support to fail due to the symbols in the version script not being defined, which will cause the version script to not be used, and the build will fail due to --no-undefined-version. This patch adds '-Wl,--undefined-version' to the args of the configure check. Signed-off-by: Violet Purcell <vimproved@inventati.org>
vimproved added a commit
to vimproved/gentoo
that referenced
this pull request
Jul 20, 2023
Upstream PR: intel/libva#732 In the upcoming LLD 17 (and previously in LLD 16.0.0, but reverted in 16.0.1), --no-undefined-version is becoming the default behavior. This causes the configure check for --version-scripts support to fail due to the symbols in the version script not being defined, which will cause the version script to not be used, and the build will fail due to --no-undefined-version. This patch adds '-Wl,--undefined-version' to the args of the configure check. Signed-off-by: Violet Purcell <vimproved@inventati.org>
XinfengZhang
commented
Sep 13, 2023
Contributor
@vimproved , could you help to address the action issue? |
vimproved
commented
Sep 13, 2023
Author
Yes, sorry. I've been meaning to look at this for a while now, since I think this PR is not the best approach. |
LLD 17 uses --no-undefined-version by default, so the check currently fails due to vaCreateSurface being undefined. This commit replaces that check with a generic check in the top level meson.build, using the conftest.syms file. Signed-off-by: Violet Purcell <vimproved@inventati.org>
vimproved
commented
Oct 2, 2023
Author
Updated this PR with a different method of fixing that should be more correct. |
vimproved added a commit
to vimproved/gentoo
that referenced
this pull request
Oct 12, 2023
Upstream-PR: intel/libva#732 Signed-off-by: Violet Purcell <vimproved@inventati.org>
vimproved added a commit
to vimproved/gentoo
that referenced
this pull request
Oct 12, 2023
Upstream-PR: intel/libva#732 Signed-off-by: Violet Purcell <vimproved@inventati.org>
nvinson added a commit
to nvinson/gentoo
that referenced
this pull request
Jan 15, 2024
Backport proposed upstream patch from intel/libva#732 Fixes Gentoo bug: 919505 ( https://bugs.gentoo.org/919505 ) Signed-off-by: Nicholas Vinson <nvinson234@gmail.com>
nvinson added a commit
to nvinson/gentoo
that referenced
this pull request
Jan 15, 2024
Backport proposed upstream patch from intel/libva#732 Bug: 919505 Signed-off-by: Nicholas Vinson <nvinson234@gmail.com>
nvinson added a commit
to nvinson/gentoo
that referenced
this pull request
Jan 15, 2024
Backport proposed upstream patch from intel/libva#732 Bug: https://bugs.gentoo.org/919505 Signed-off-by: Nicholas Vinson <nvinson234@gmail.com>
gentoo-bot pushed a commit
to gentoo/gentoo
that referenced
this pull request
Jan 17, 2024
Backport proposed upstream patch from intel/libva#732 Bug: https://bugs.gentoo.org/919505 Signed-off-by: Nicholas Vinson <nvinson234@gmail.com> Closes: #34818 Signed-off-by: Sam James <sam@gentoo.org>
gentoo-bot pushed a commit
to gentoo/gentoo
that referenced
this pull request
May 6, 2024
Upstream-PR: intel/libva#732 Closes: https://bugs.gentoo.org/915200Closes: #33314 Signed-off-by: Violet Purcell <vimproved@inventati.org> Signed-off-by: Matt Turner <mattst88@gentoo.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the upcoming LLD 17 (and previously in LLD 16.0.0, but reverted in 16.0.1), --no-undefined-version is becoming the default behavior. This causes the configure check for --version-scripts support to fail due to the symbols in the version script not being defined, which will cause the version script to not be used, and the build will fail due to --no-undefined-version. This commit adds '-Wl,--undefined-version' to the args of the configure check.