Skip to content
This repository was archived by the owner on Aug 5, 2022. It is now read-only.

Add listMappings command - #366

Open
terahlunah wants to merge 1 commit into
intel:masterfrom
terahlunah:mappings
Open

Add listMappings command#366
terahlunah wants to merge 1 commit into
intel:masterfrom
terahlunah:mappings

Conversation

@terahlunah

@terahlunahterahlunah commented May 2, 2016

Copy link
Copy Markdown

Add the listMappings command which list all the mappings under a given path

Example with the MusicLibrary form the Getting Started wiki :

$ remote-process localhost 5000 listMappings /MusicLibrary/my_library/artists/IronMaiden

/MusicLibrary/my_library/artists/IronMaiden [Directory:/home/fponcabx/pfw/install-examples/libraries, File:ironMaiden, File:ironMaiden]

@@ master #366 diff @@
========================================
Files 211 211
Lines 7169 7188 +19
Methods 0 0
Branches 0 0
========================================
Hits 5760 5760
- Misses 1409 1428 +19
Partials 0 0

Powered by Codecov. Last updated by 1d51444...757ae75

  • File: parameter/ParameterMgr.cpp:L1822-1859
  • <img border=0 src='https://avatars.githubusercontent.com/u/124108?v=3' height=16 width=16'> Can you check if you can dump only the terminal element. Today you are listing the full list of element. So to many element without control are listed. See under:
    /Audio/REALTEK/SOUND_CARD/OUTPUT/HEADPHONE/ANALOG/VOLUME => Card:bytcrrt5640, Debug:, Amend1:HP, Volume:'%1 Playback Volume', Volume:HP Playback Volume
    /Audio/REALTEK/SOUND_CARD/OUTPUT/HEADPHONE/ANALOG/VOLUME/0 => Card:bytcrrt5640, Debug:, Amend1:HP, Volume:'%1 Playback Volume', Volume:'%1 Playback Volume'
    /Audio/REALTEK/SOUND_CARD/OUTPUT/EARPIECE/ANALOG => Card:bytcrrt5640, Debug:
    /Audio/REALTEK/SOUND_CARD/OUTPUT/EARPIECE/ANALOG/SWITCH => Card:bytcrrt5640, Debug:, Control:'Mono Playback Switch', Control:Mono Playback Switch
  • <img border=0 src='https://avatars.githubusercontent.com/u/6430928?v=3' height=16 width=16'> What you seem to want isn't the terminal element (i.e. leaves, i.e. parameters) but the SubsystemObjects (the elements with an instantiation mapping).


@dawagner

Copy link
Copy Markdown
Contributor

Please add the example's output in your commit message too.

List all the mapping under a given path
Example with the MusicLibrary form the Getting Started wiki :
$ remote-process localhost 5000 listMappings /MusicLibrary/my_library/artists/IronMaiden
/MusicLibrary/my_library/artists/IronMaiden [Directory:/home/fponcabx/pfw/install-examples/libraries, File:ironMaiden, File:ironMaiden]
Signed-off-by: Florian Poncabaré <florianx.poncabare@intel.com>
@codecov-io

codecov-io commented May 2, 2016

Copy link
Copy Markdown

Current coverage is 80.13%

Merging #366 into master will increase coverage by -0.19%

@@ master #366 diff @@
========================================
Files 211 211 Lines 7169 7188 +19 Methods 0 0 Branches 0 0 ========================================
Hits 5760 5760 - Misses 1409 1428 +19 
Partials 0 0 

Powered by Codecov. Last updated by 1d51444...757ae75


for (string path : paths) {
string mapping;
if (getParameterMapping(path, mapping)) {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check if you can dump only the terminal element. Today you are listing the full list of element. So to many element without control are listed. See under:

/Audio/REALTEK/SOUND_CARD/OUTPUT/HEADPHONE/ANALOG/VOLUME => Card:bytcrrt5640, Debug:, Amend1:HP, Volume:'%1 Playback Volume', Volume:HP Playback Volume
/Audio/REALTEK/SOUND_CARD/OUTPUT/HEADPHONE/ANALOG/VOLUME/0 => Card:bytcrrt5640, Debug:, Amend1:HP, Volume:'%1 Playback Volume', Volume:'%1 Playback Volume'

/Audio/REALTEK/SOUND_CARD/OUTPUT/EARPIECE/ANALOG => Card:bytcrrt5640, Debug:
/Audio/REALTEK/SOUND_CARD/OUTPUT/EARPIECE/ANALOG/SWITCH => Card:bytcrrt5640, Debug:, Control:'Mono Playback Switch', Control:Mono Playback Switch

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What you seem to want isn't the terminal element (i.e. leaves, i.e. parameters) but the SubsystemObjects (the elements with an instantiation mapping).

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@terahlunah@dawagner@codecov-io@sguiriec