Uh oh!
There was an error while loading. Please reload this page.
remove erubis dependency - #103
Closed
jjb wants to merge 1 commit into
Closed
Conversation
result_with_hash became available in ruby 2.5.0
jjbforce-pushed
the
remove-erubis-dependency
branch
from
October 12, 2021 22:06
adddd75 to
7bbfe8eComparekreintjes
commented
Oct 2, 2024
Nice. The less dependencies the better :) @schneems could you maybe have a look at this? Heroics (through platform-api) is the only thing requiring erubis for a lot of our projects now. |
beanieboi pushed a commit
that referenced
this pull request
Apr 22, 2026
beanieboi
commented
Apr 22, 2026
Member
thank you for this :) |
schneems
commented
Jun 3, 2026
Collaborator
schneems added a commit
to heroku/platform-api
that referenced
this pull request
Jun 3, 2026
schneems added a commit
to heroku/platform-api
that referenced
this pull request
Jun 4, 2026
* Replace MultiJson.load with JSON.parse heroics 0.1.4 dropped its multi_json dependency in favor of Ruby's built-in json library. Since platform-api never declared multi_json as a direct dependency, upgrading heroics causes: NameError: uninitialized constant PlatformAPI::MultiJson Replace the single MultiJson.load call with JSON.parse, which is available from the standard library and requires no new dependencies. Fixes#150 * Add CHANGELOG entry for MultiJson fix * whitespace Due to interagent/heroics#103 * Trim trailing whitespace * v3.9.1 * Apply suggestions from code review Co-authored-by: Ed Morley <501702+edmorley@users.noreply.github.com> Signed-off-by: Richard Schneeman <richard.schneeman+no-recruiters@gmail.com> --------- Signed-off-by: Richard Schneeman <richard.schneeman+no-recruiters@gmail.com> Co-authored-by: Ed Morley <501702+edmorley@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

erubis hasn't been updated since 2011, and stdlib ERB is probably sufficient, so maybe it would be nice to remove this dependency.
AFAIK the template is not run often at runtime, so performance is not a concern. If it is, the erubi gem might be a good option. erubi would be preferable to erubis, because erubi is widely uses, including by rails.
tests pass with ruby 3, below. not sure if the test is comprehensive, maybe someone with some complicated use cases could stress test this as well.
result_with_hash became available in ruby 2.5, so i added that requirement. if we don't want to introduce that limitation, I also had a working version with this approach: