Fix missing callback action error

[JoshAntBrown]

Using the library with Rails 7.1 currently results in this error:

The unlock action could not be found for the :check_for_lockup callback on SomeController, but it is listed in the controller's :except option.

Raising for missing callback actions is a new default in Rails 7.1, if you'd like to turn this off you can delete the option from the environment configurations or set config.action_controller.raise_on_missing_callback_actions to false.

This is because the unlock action does not exist in my applications controllers, nor should I add the unlock action to those controllers.

The LockupController responsible for unlocking already has a skip_before_action/filter call and means the exception was unnecessary.

lockup/app/controllers/lockup/lockup_controller.rb

Lines 5 to 9 in 86d9955

	ifself.respond_to?(:skip_before_action)
	skip_before_action:check_for_lockup
	else
	skip_before_filter:check_for_lockup
	end

---

I've solved this in my project by adding the following directly to my application controller:

 if respond_to?(:before_action)
before_action :check_for_lockup
else
before_filter :check_for_lockup
end

[nialbima]

@JoshAntBrown I'm seeing this issue with a current Rails upgrade. 6 months down the line, has this given you any trouble?

[JoshAntBrown]

I've since removed this dependency from my project because I no longer require its functionality. No issues while I was using it though

[supairish]

@gblakeman Any chance of merging this?

[gblakeman]

Has anyone tested this change with older versions of Rails? Ideally I would like this gem to maintain as much backwards compatibility as possible. I haven’t actively developed for Rails in 5+ years, so I’m not aware of 7.x changes and how they’d break gem use on versions that pre-date 7.

/cc @supairish

[JoshAntBrown]

Using the library with Rails 7.1 currently results in this error:

The unlock action could not be found for the :check_for_lockup callback on SomeController, but it is listed in the controller's :except option.

Raising for missing callback actions is a new default in Rails 7.1, if you'd like to turn this off you can delete the option from the environment configurations or set config.action_controller.raise_on_missing_callback_actions to false.

This is because the unlock action does not exist in my applications controllers, nor should I add the unlock action to those controllers.

The LockupController responsible for unlocking already has a skip_before_action/filter call and means the exception was unnecessary.

lockup/app/controllers/lockup/lockup_controller.rb

Lines 5 to 9 in 86d9955

	ifself.respond_to?(:skip_before_action)
	skip_before_action:check_for_lockup
	else
	skip_before_filter:check_for_lockup
	end

---

I've solved this in my project by adding the following directly to my application controller:

 if respond_to?(:before_action)
before_action :check_for_lockup
else
before_filter :check_for_lockup
end

[nialbima]

@JoshAntBrown I'm seeing this issue with a current Rails upgrade. 6 months down the line, has this given you any trouble?

[JoshAntBrown]

I've since removed this dependency from my project because I no longer require its functionality. No issues while I was using it though

[supairish]

@gblakeman Any chance of merging this?

[gblakeman]

Has anyone tested this change with older versions of Rails? Ideally I would like this gem to maintain as much backwards compatibility as possible. I haven’t actively developed for Rails in 5+ years, so I’m not aware of 7.x changes and how they’d break gem use on versions that pre-date 7.

/cc @supairish

[JoshAntBrown]

Using the library with Rails 7.1 currently results in this error:

The unlock action could not be found for the :check_for_lockup callback on SomeController, but it is listed in the controller's :except option.

Raising for missing callback actions is a new default in Rails 7.1, if you'd like to turn this off you can delete the option from the environment configurations or set config.action_controller.raise_on_missing_callback_actions to false.

This is because the unlock action does not exist in my applications controllers, nor should I add the unlock action to those controllers.

The LockupController responsible for unlocking already has a skip_before_action/filter call and means the exception was unnecessary.

lockup/app/controllers/lockup/lockup_controller.rb

Lines 5 to 9 in 86d9955

	ifself.respond_to?(:skip_before_action)
	skip_before_action:check_for_lockup
	else
	skip_before_filter:check_for_lockup
	end

---

I've solved this in my project by adding the following directly to my application controller:

 if respond_to?(:before_action)
before_action :check_for_lockup
else
before_filter :check_for_lockup
end

[nialbima]

@JoshAntBrown I'm seeing this issue with a current Rails upgrade. 6 months down the line, has this given you any trouble?

[JoshAntBrown]

I've since removed this dependency from my project because I no longer require its functionality. No issues while I was using it though

[supairish]

@gblakeman Any chance of merging this?

[gblakeman]

Has anyone tested this change with older versions of Rails? Ideally I would like this gem to maintain as much backwards compatibility as possible. I haven’t actively developed for Rails in 5+ years, so I’m not aware of 7.x changes and how they’d break gem use on versions that pre-date 7.

/cc @supairish

[JoshAntBrown]

Using the library with Rails 7.1 currently results in this error:

The unlock action could not be found for the :check_for_lockup callback on SomeController, but it is listed in the controller's :except option.

Raising for missing callback actions is a new default in Rails 7.1, if you'd like to turn this off you can delete the option from the environment configurations or set config.action_controller.raise_on_missing_callback_actions to false.

This is because the unlock action does not exist in my applications controllers, nor should I add the unlock action to those controllers.

The LockupController responsible for unlocking already has a skip_before_action/filter call and means the exception was unnecessary.

lockup/app/controllers/lockup/lockup_controller.rb

Lines 5 to 9 in 86d9955

	ifself.respond_to?(:skip_before_action)
	skip_before_action:check_for_lockup
	else
	skip_before_filter:check_for_lockup
	end

---

I've solved this in my project by adding the following directly to my application controller:

 if respond_to?(:before_action)
before_action :check_for_lockup
else
before_filter :check_for_lockup
end

[nialbima]

@JoshAntBrown I'm seeing this issue with a current Rails upgrade. 6 months down the line, has this given you any trouble?

[JoshAntBrown]

I've since removed this dependency from my project because I no longer require its functionality. No issues while I was using it though

[supairish]

@gblakeman Any chance of merging this?

[gblakeman]

Has anyone tested this change with older versions of Rails? Ideally I would like this gem to maintain as much backwards compatibility as possible. I haven’t actively developed for Rails in 5+ years, so I’m not aware of 7.x changes and how they’d break gem use on versions that pre-date 7.

/cc @supairish

[JoshAntBrown]

Using the library with Rails 7.1 currently results in this error:

The unlock action could not be found for the :check_for_lockup callback on SomeController, but it is listed in the controller's :except option.

Raising for missing callback actions is a new default in Rails 7.1, if you'd like to turn this off you can delete the option from the environment configurations or set config.action_controller.raise_on_missing_callback_actions to false.

This is because the unlock action does not exist in my applications controllers, nor should I add the unlock action to those controllers.

The LockupController responsible for unlocking already has a skip_before_action/filter call and means the exception was unnecessary.

lockup/app/controllers/lockup/lockup_controller.rb

Lines 5 to 9 in 86d9955

	ifself.respond_to?(:skip_before_action)
	skip_before_action:check_for_lockup
	else
	skip_before_filter:check_for_lockup
	end

---

I've solved this in my project by adding the following directly to my application controller:

 if respond_to?(:before_action)
before_action :check_for_lockup
else
before_filter :check_for_lockup
end

[nialbima]

@JoshAntBrown I'm seeing this issue with a current Rails upgrade. 6 months down the line, has this given you any trouble?

[JoshAntBrown]

I've since removed this dependency from my project because I no longer require its functionality. No issues while I was using it though

[supairish]

@gblakeman Any chance of merging this?

[gblakeman]

Has anyone tested this change with older versions of Rails? Ideally I would like this gem to maintain as much backwards compatibility as possible. I haven’t actively developed for Rails in 5+ years, so I’m not aware of 7.x changes and how they’d break gem use on versions that pre-date 7.

/cc @supairish

[JoshAntBrown]

Using the library with Rails 7.1 currently results in this error:

The unlock action could not be found for the :check_for_lockup callback on SomeController, but it is listed in the controller's :except option.

Raising for missing callback actions is a new default in Rails 7.1, if you'd like to turn this off you can delete the option from the environment configurations or set config.action_controller.raise_on_missing_callback_actions to false.

This is because the unlock action does not exist in my applications controllers, nor should I add the unlock action to those controllers.

The LockupController responsible for unlocking already has a skip_before_action/filter call and means the exception was unnecessary.

lockup/app/controllers/lockup/lockup_controller.rb

Lines 5 to 9 in 86d9955

	ifself.respond_to?(:skip_before_action)
	skip_before_action:check_for_lockup
	else
	skip_before_filter:check_for_lockup
	end

---

I've solved this in my project by adding the following directly to my application controller:

 if respond_to?(:before_action)
before_action :check_for_lockup
else
before_filter :check_for_lockup
end

[nialbima]

@JoshAntBrown I'm seeing this issue with a current Rails upgrade. 6 months down the line, has this given you any trouble?

[JoshAntBrown]

I've since removed this dependency from my project because I no longer require its functionality. No issues while I was using it though

[supairish]

@gblakeman Any chance of merging this?

[gblakeman]

Has anyone tested this change with older versions of Rails? Ideally I would like this gem to maintain as much backwards compatibility as possible. I haven’t actively developed for Rails in 5+ years, so I’m not aware of 7.x changes and how they’d break gem use on versions that pre-date 7.

/cc @supairish

[JoshAntBrown]

Using the library with Rails 7.1 currently results in this error:

The unlock action could not be found for the :check_for_lockup callback on SomeController, but it is listed in the controller's :except option.

Raising for missing callback actions is a new default in Rails 7.1, if you'd like to turn this off you can delete the option from the environment configurations or set config.action_controller.raise_on_missing_callback_actions to false.

This is because the unlock action does not exist in my applications controllers, nor should I add the unlock action to those controllers.

The LockupController responsible for unlocking already has a skip_before_action/filter call and means the exception was unnecessary.

lockup/app/controllers/lockup/lockup_controller.rb

Lines 5 to 9 in 86d9955

	ifself.respond_to?(:skip_before_action)
	skip_before_action:check_for_lockup
	else
	skip_before_filter:check_for_lockup
	end

---

I've solved this in my project by adding the following directly to my application controller:

 if respond_to?(:before_action)
before_action :check_for_lockup
else
before_filter :check_for_lockup
end

[nialbima]

@JoshAntBrown I'm seeing this issue with a current Rails upgrade. 6 months down the line, has this given you any trouble?

[JoshAntBrown]

I've since removed this dependency from my project because I no longer require its functionality. No issues while I was using it though

[supairish]

@gblakeman Any chance of merging this?

[gblakeman]

Has anyone tested this change with older versions of Rails? Ideally I would like this gem to maintain as much backwards compatibility as possible. I haven’t actively developed for Rails in 5+ years, so I’m not aware of 7.x changes and how they’d break gem use on versions that pre-date 7.

/cc @supairish

[JoshAntBrown]

Using the library with Rails 7.1 currently results in this error:

The unlock action could not be found for the :check_for_lockup callback on SomeController, but it is listed in the controller's :except option.

Raising for missing callback actions is a new default in Rails 7.1, if you'd like to turn this off you can delete the option from the environment configurations or set config.action_controller.raise_on_missing_callback_actions to false.

This is because the unlock action does not exist in my applications controllers, nor should I add the unlock action to those controllers.

The LockupController responsible for unlocking already has a skip_before_action/filter call and means the exception was unnecessary.

lockup/app/controllers/lockup/lockup_controller.rb

Lines 5 to 9 in 86d9955

	ifself.respond_to?(:skip_before_action)
	skip_before_action:check_for_lockup
	else
	skip_before_filter:check_for_lockup
	end

---

I've solved this in my project by adding the following directly to my application controller:

 if respond_to?(:before_action)
before_action :check_for_lockup
else
before_filter :check_for_lockup
end

[nialbima]

@JoshAntBrown I'm seeing this issue with a current Rails upgrade. 6 months down the line, has this given you any trouble?

[JoshAntBrown]

I've since removed this dependency from my project because I no longer require its functionality. No issues while I was using it though

[supairish]

@gblakeman Any chance of merging this?

[gblakeman]

Has anyone tested this change with older versions of Rails? Ideally I would like this gem to maintain as much backwards compatibility as possible. I haven’t actively developed for Rails in 5+ years, so I’m not aware of 7.x changes and how they’d break gem use on versions that pre-date 7.

/cc @supairish