Skip to content

Added BGNPCGN Modern Syriac map 2011 - #11

Closed
manuelfuenmayor wants to merge 2 commits into
mainfrom
romanization-modern-syriac
Closed

Added BGNPCGN Modern Syriac map 2011#11
manuelfuenmayor wants to merge 2 commits into
mainfrom
romanization-modern-syriac

Conversation

@manuelfuenmayor

@manuelfuenmayormanuelfuenmayor commented Nov 21, 2019

Copy link
Copy Markdown
Contributor

Hi Ron,

I have several transliterations set already. But I'd like you to review this one to see if I'm on track.

Thanks!

@manuelfuenmayormanuelfuenmayor self-assigned this Nov 21, 2019
andrew2net
andrew2net reviewed Nov 21, 2019
View reviewed changes

@andrew2netandrew2net left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to define at least one test case for each transliteration system. Please add source and expected in the test section.

@ronaldtse
ronaldtseforce-pushed the romanization-modern-syriac branch from e9b3be5 to cdb602bCompareNovember 25, 2019 03:49
@ronaldtse

ronaldtse commented Nov 25, 2019

Copy link
Copy Markdown
Contributor

We need to define at least one test case for each transliteration system. Please add source and expected in the test section.

Right, but it seems that the source reference doesn't provide any examples. Will need to find them...

@ronaldtseronaldtse mentioned this pull request Jun 8, 2020
Open
@AhMohsen46

AhMohsen46 commented Sep 27, 2020

Copy link
Copy Markdown
Contributor

@ronaldtse related doc is having arabic equivalents, but it's not basically arabic, I -unforunately- don't think I can do this
however, if we had no other option I may do a little bit of exploration and transliterate the 22 letter language as per the doc, but I can't guarantee a 100% of success and test coverage

@ronaldtseronaldtse mentioned this pull request Oct 7, 2021
Open
@ronaldtse

ronaldtse commented Oct 7, 2021

Copy link
Copy Markdown
Contributor

Replaced with interscript/maps#167.

@ronaldtse
ronaldtse deleted the romanization-modern-syriac branch October 7, 2021 10:09
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrew2netandrew2netandrew2net left review comments
@ronaldtseronaldtseAwaiting requested review from ronaldtse

Assignees

@manuelfuenmayormanuelfuenmayor

@AhMohsen46AhMohsen46

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@manuelfuenmayor@ronaldtse@AhMohsen46@andrew2net