Uh oh!
There was an error while loading. Please reload this page.
Added UNGEGN Amharic 2016 system - #32
Conversation
087297e to
f908904Compareronaldtse
commented
Sep 11, 2020
Ping @tsega for this |
@ronaldtse two issues why the tests are failing here:
This I have corrected by adding the consonant only as the second entry in the yaml;
How do I fix the second issue? |
ronaldtse
commented
Sep 12, 2020
@tsega thanks for this.
Should we instead use
What do locations at unstats.un.org do for capitalization? We probably should follow them, e.g. if they are all downcased we should also downcase. |
tsega
commented
Sep 13, 2020
@ronaldtse location names from unstats.un.org are all capitalized when transliterated into English since they are names of places. Is the sample data only names of locations? If so, then the tests are consistent in capitalizing the results and I would need to change my test data. However, I was under the impression that the test data can come from anywhere and just has to be mapped correctly. |
ronaldtse
commented
Sep 13, 2020
We will need to use machine learning to decide whether a word is a name (place, people) or not, so at this point we can just keep all examples in lower case. If that's fine we can merge and consider this done. |
ronaldtse
commented
Sep 16, 2020
Completed in #414 |
Specification here: http://www.eki.ee/wgrs/rom1_am.htm