Skip to content

bgnpcgn-ara-Arab-Latn-1956 init commit - #371

Merged
ronaldtse merged 2 commits into
interscript:masterfrom
AhMohsen46:bgnpcgn-ara-arab-latn-1956
Sep 7, 2020
Merged

bgnpcgn-ara-Arab-Latn-1956 init commit#371
ronaldtse merged 2 commits into
interscript:masterfrom
AhMohsen46:bgnpcgn-ara-arab-latn-1956

Conversation

@AhMohsen46

Copy link
Copy Markdown
Contributor

No description provided.

@AhMohsen46AhMohsen46 changed the title bgnpcgn-ara-Arab-Latn-1956 init commitWIP: bgnpcgn-ara-Arab-Latn-1956 init commitSep 6, 2020
@ronaldtse

Copy link
Copy Markdown
Contributor

Thanks @AhMohsen46 ! So once we have the sun letters this is good to go?

@ronaldtse

Copy link
Copy Markdown
Contributor

@AhMohsen46 could you help check the original spec in https://github.com/interscript/interscript/issues/60#issuecomment-687987713 ? Thanks.

@AhMohsen46

Copy link
Copy Markdown
ContributorAuthor

@ronaldtse will finish sun letters and check this now

@AhMohsen46AhMohsen46 changed the title WIP: bgnpcgn-ara-Arab-Latn-1956 init commitbgnpcgn-ara-Arab-Latn-1956 init commitSep 7, 2020
@AhMohsen46

Copy link
Copy Markdown
ContributorAuthor

@ronaldtse sun letters are now done and pushed

I guess it's good to be merged, I'll try in the next hour to start checking how to run it on our dataset to generate pointing from the transliterated words

only one thing required for all the previous arab maps
the issue for capitalizing the first letter of each word, there is a way to do it
the exact same way like here https://github.com/interscript/interscript//blob/a95ee43317c08fdc775c3c5a09c381cc0a1affe1/maps/acadsin-zho-Hani-Latn-2002.yaml#L25
but it may take effort as we've more than the normal 26 english letters

or there is an easy work around, but may require a modification in here
https://github.com/interscript/interscript//blob/22600b4f383643966058818fc0cbd9a79b5eb610/lib/interscript.rb#L109

that I condition on the result

if result == "upcase"
I convert the letter to upcase and that's it, would be optimum I guess

@ronaldtse

Copy link
Copy Markdown
Contributor

Thank you @AhMohsen46 ! Merging.

@ronaldtse
ronaldtse merged commit 3b0a350 into interscript:masterSep 7, 2020
@AhMohsen46

Copy link
Copy Markdown
ContributorAuthor

Great, Thanks @ronaldtse

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@AhMohsen46@ronaldtse