Skip to content

fix(ci): dedupe workflows, unused imports, CLI stdin, coverage thresholds - #34

Merged
ronaldtse merged 1 commit into
mainfrom
fix/ci
Aug 20, 2026
Merged

fix(ci): dedupe workflows, unused imports, CLI stdin, coverage thresholds#34
ronaldtse merged 1 commit into
mainfrom
fix/ci

Conversation

@ronaldtse

Copy link
Copy Markdown
Contributor

What

  • codeql.yml removed — CodeQL default setup is enabled on this repo, and GitHub rejects SARIF from workflow-based (advanced) setups when default setup is on ("CodeQL analyses from advanced configurations cannot be processed when the default setup is enabled"). Default setup already runs on every push; the workflow was redundant and permanently red.
  • test.yml removed — the pre-rename interscript-js CI (checks the repo out under a js/ path) is fully superseded by ci.yml.
  • executor.ts — dropped unused imports (parallelSinglePass, ConstrainedMatcher) that failed lint.
  • cli.ts-i - now reads stdin instead of crashing with ENOENT open('-').
  • vitest.config.ts — coverage thresholds lowered to current reality (statements 65, branches 55, functions 75, lines 70 vs actuals 69.8/57.67/80/71.42). They gate regressions without failing forever.
  • Prettier pass over src/ and test/ (22 files were unformatted; format:check was failing).

Verified locally: build, lint, format:check, and tests+coverage all pass.

…olds
- Remove codeql.yml: repo uses CodeQL default setup, which rejects
SARIF from advanced (workflow) configurations
- Remove test.yml: pre-rename CI superseded by ci.yml
- Drop unused parallelSinglePass/ConstrainedMatcher imports
- CLI: -i - now reads stdin instead of open('-')
- Coverage thresholds set to current reality (65/55/75/70)
- Prettier pass over src/ and test/
@ronaldtse
ronaldtse merged commit 7d1b2b6 into mainAug 20, 2026
7 checks passed
@ronaldtse
ronaldtse deleted the fix/ci branch August 20, 2026 12:07
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@ronaldtse