Kotkovets Gennadiy - #49
Open
ge2nadiy wants to merge 17 commits into
Open
Conversation
| long_description = f.read() | ||
| setup( |
Collaborator
There was a problem hiding this comment.
почему-то help нехочет работать
# rss-reader --help
Traceback (most recent call last):
File "/usr/local/bin/rss-reader", line 8, in<module>sys.exit(main())
File "/usr/local/lib/python3.8/site-packages/rss_app/main.py", line 21, in main
args=get_args()
File "/usr/local/lib/python3.8/site-packages/rss_app/main.py", line 17, in get_args
args = parser.parse_args()
File "/usr/local/lib/python3.8/argparse.py", line 1768, in parse_args
args, argv = self.parse_known_args(args, namespace)
File "/usr/local/lib/python3.8/argparse.py", line 1800, in parse_known_args
namespace, args = self._parse_known_args(args, namespace)
File "/usr/local/lib/python3.8/argparse.py", line 2006, in _parse_known_args
start_index = consume_optional(start_index)
File "/usr/local/lib/python3.8/argparse.py", line 1946, in consume_optional
take_action(action, args, option_string)
File "/usr/local/lib/python3.8/argparse.py", line 1874, in take_action
action(self, namespace, argument_values, option_string)
File "/usr/local/lib/python3.8/argparse.py", line 1044, in __call__
parser.print_help()
File "/usr/local/lib/python3.8/argparse.py", line 2493, in print_help
self._print_message(self.format_help(), file)
File "/usr/local/lib/python3.8/argparse.py", line 2477, in format_help
returnformatter.format_help()
File "/usr/local/lib/python3.8/argparse.py", line 282, in format_help
help = self._root_section.format_help()
File "/usr/local/lib/python3.8/argparse.py", line 213, in format_help
item_help = join([func(*args) forfunc, argsin self.items])
File "/usr/local/lib/python3.8/argparse.py", line 213, in<listcomp>
item_help = join([func(*args) forfunc, argsin self.items])
File "/usr/local/lib/python3.8/argparse.py", line 213, in format_help
item_help = join([func(*args) forfunc, argsin self.items])
File "/usr/local/lib/python3.8/argparse.py", line 213, in<listcomp>
item_help = join([func(*args) forfunc, argsin self.items])
File "/usr/local/lib/python3.8/argparse.py", line 529, in _format_action
help_text = self._expand_help(action)
File "/usr/local/lib/python3.8/argparse.py", line 621, in _expand_help
return self._get_help_string(action) % params
ValueError: unsupported format character 'Y' (0x59) at index 26| def print_news(self, entries): | ||
| self.log.info("Printing news") | ||
| for thefeedentry in entries: |
| "Link": thefeedentry.link, | ||
| "Discription": BeautifulSoup(thefeedentry.description, "html.parser").text | ||
| } | ||
| print("--------------------------------------------------") |
Collaborator
There was a problem hiding this comment.
с аргументом --json утилита должна выводить json в консоль (чтобы этот аутпут можно было в прямом смысле конвертировать в json и использовать в других утилитах)
Однако сейчас аутпут не является корреткным json
нужно удалить эти раздилители в виде черточек и запихнуть все новости в список
AlexeiBuzuma
commented
Feb 3, 2020
Collaborator
Моменты, которые можно улучшить:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.