feat(webv2): video Concepts and Model Components sections - #129
Merged
Conversation
lstein
requested review from
JPPhoto,
Pfannkuchensack and
blessedcoolant
as code owners
August 20, 2026 02:38
lstein
force-pushed
the
feat/video-panel-05-media
branch
from
August 21, 2026 00:50
11ff3b4 to
c75cc30
Compare
lstein
force-pushed
the
feat/video-panel-06-concepts
branch
from
August 21, 2026 00:50
ff01908 to
7e6386f
Compare
lstein
force-pushed
the
feat/video-panel-05-media
branch
from
August 21, 2026 02:37
c75cc30 to
b8c17bd
Compare
lstein
force-pushed
the
feat/video-panel-06-concepts
branch
4 times, most recently
from
August 22, 2026 02:23
33163f7 to
f496d04
Compare
Adds the panel's last two sections (PR 6 of the stack): - Concepts: a LoRA adder filtered by the shared generation compatibility rule (which already encodes Wan's A14B/5B family split and rejects cross-base LoRAs for MiniMax H3), with enable/weight/remove rows. Expert routing stays the graph's job — 'auto' reads each LoRA's probed high/low tag — so rows carry no target control. - Model Components: fully policy-driven off the capability matrix, like the generation panel — single-file Wan mains get Component Source / VAE (latent-channel filtered) / Wan T5 / low-noise expert slots with requiredness bound to whether a Diffusers source covers them; Diffusers Wan mains offer only the optional VAE/T5 overrides (the loader ignores a component source for them, so that slot is suppressed and can never list the selected main itself); MiniMax H3 gets its two optional single-file overrides. - The accelerator invariant now covers enablement, not just presence: removing OR disabling one of its LoRAs turns the fast path off, restores the model's own steps/CFG (Lightning wrote them), and says so with a toast — a silent 4-step run without the distillation pair would just look like a broken model. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Capture this branch's bundle footprint on the re-based parent baseline; platform-ui barrel importer budget raised to the actual count (159). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
lstein
force-pushed
the
feat/video-panel-06-concepts
branch
from
August 22, 2026 02:49
f496d04 to
db54421
Compare
…e accelerator The Concepts setter already restores steps/CFG and toasts when the user removes or disables an accelerator LoRA, but the catalog reconciler cleared only the flag: uninstalling a pair member from the Model Manager left a silent 4-step / CFG 1 setup with no distillation pair — output that reads as a broken model. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LUjUcPHzQCoL7dqgsVzi63
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 6 of the Video generation panel stack — stacked on #128. The panel's section list now matches the design sketch end to end.
Concepts
A LoRA adder + rows (enable / weight / remove), compatibility-filtered through the shared generation rule — Wan's A14B ⇄ 5B family split and H3's base isolation come for free. Expert routing stays in the graph (
autoreads each LoRA's probed high/low tag), so rows carry no target control.Accelerator interplay (from this PR's adversarial review): the fast-path invariant now covers enablement, not just presence — removing or disabling one of the accelerator's LoRA rows turns the accelerator off, restores the model's own steps/CFG (Lightning wrote 4/1 over them), keeps your list edit, and toasts why. Previously a disabled row would silently run 4 steps without the distillation pair.
Model Components
Fully policy-driven off the capability matrix, mirroring the generation panel's slot machinery:
Verification
Adversarial fresh-context review; all four confirmed findings fixed with regression tests (disabled-row fast-path gutting, half-pair sampling asymmetry, the no-op component-source slot on Diffusers mains + self-listing, stale row names after catalog renames). Slot coercion, ctx fidelity/liveness, duplicate-add and null-model paths, and the render-performance contract all attacked and held. Full suite 477 files / 6329 tests;
tsc/oxlint/formatclean.🤖 Generated with Claude Code