[bug]: Arrow keys no longer navigate gallery items after generating

[ufuksarp]

Is there an existing issue for this problem?

• I have searched the existing issues

Install method

Invoke's Launcher

Operating system

Windows

GPU vendor

Nvidia (CUDA)

GPU model

4070 Ti Super

GPU VRAM

16

Version number

v6.8.0rc1

Browser

Edge latest

What happened

After generating an image in the Generate tab (using either CTRL+Enter or clicking Invoke), the arrow keys no longer navigate gallery items. Instead, focus borders appear in the new top bar (launchpad, viewer, etc). Previously, it was possible to navigate the gallery without clicking inside it.

Clicking the viewer image also no longer restores this behavior. Navigation with arrow keys only works if the gallery itself is focused/clicked.

[the-space-fish]

Additionally, I've noticed that arrow keys no longer work to cycle images on the viewer when the gallery pane is hidden (e.g., press 'F' to get a larger view of the images with just the viewer - you used to be able to press left and right to navigate them, which was handy, but no longer works).

[ufuksarp]

This has not been fixed. Re-open please.

[the-space-fish]

Indeed - looks like the above activity was on a fork.

[DustyShoe]

@the-space-fish
That's how it is done if you are not a collaborator.
You fork the repo and create branch based off your fork.
Make changes and open pull request to merge your branch with main repo.
That PR was merged to main repo. The merge symbol confirms it:

[DustyShoe]

Describe precisely how would you expect browsing to work.
I'm assuming it have to autofocus on gallery only when Viewer tab is active.
Because autofocus on gallery can create some conflicts while being in Canvas mode.

[the-space-fish]

@DustyShoe - I'll take your word for it, but whatever you tried to link isn't accessible to me, and the PR linked in this issue, at least, was to a separate published fork of the InvokeAI repo - "MK-986123/InvokeAI" (not to be confused with a development branch off of the canonical one - "invoke-ai/InvokeAI"), and I didn't find any version of said PR in the primary repo.

In any case, I'll let @ufuksarp speak to the desired or expected behavior on the interface post-generation. My observation/concern in particular was that when the gallery is hidden (such as when pressing 'F' to get the preview pane alone), navigating images by arrow keys is no longer possible when once it was. Whether it'd be cleaner to have the arrow key events pass through to the gallery when the preview pane is focused, or have the preview pane handle the events itself as its own navigation commands, I couldn't say.

[ufuksarp]

I’ve noticed this issue primarily on the T2I tab, not on the Canvas tab, and I don’t remember how it behaved there before to be honest.

In the context of the T2I behavior, after clicking “Invoke” or using the hotkey, the focus shifts to the top bar, which I don't think serves a useful purpose. Previously, it allowed immediate navigation after submitting a generation, likely by moving the focus to the Gallery.

[DustyShoe]

I've created a PR to address this issue. Go take it for a spin. It is more complicated than what was originally implemented.
It respects mode changes and all cases with panels closed/open. Also respects hotkey for Invoke usage.

[the-space-fish]

@DustyShoe - I set up a dev environment and checked out your PR, and it's looking good for me, at least! Confirmed that:

• Left and right arrow keys navigate between images in preview pane only mode ('F') / my use case
• Left and right arrow keys navigate between images when only the gallery / right pane is closed
• Arrow key navigation is immediately possible after starting a generation, whether button or CRTL-Enter (@ufuksarp 's use case, I believe)
• When clicking in text editable fields (prompt, size, steps, etc.), arrow keys respond appropriately within those fields
• When clicking outside of editable fields on other arbitrary areas to de-focus any editable fields, the arrow keys return to navigating the gallery
• Up and Down work when the gallery and its highlighted image is visible, but not when the gallery is hidden (i.e., Left and Right only with just the preview pane), which feels appropriate
• Arrow keys do not default to gallery navigation on the Canvas tab (also feels appropriate)

Thanks a bunch for all the effort on a thorough fix!