Skip to content

[FEATURE] LyCORIS support in 2.3 - #3118

Merged
lstein merged 3 commits into
invoke-ai:feat/lora-support-2.3from
StAlKeR7779:feat/lycoris-support-2.3
Apr 6, 2023
Merged

[FEATURE] LyCORIS support in 2.3#3118
lstein merged 3 commits into
invoke-ai:feat/lora-support-2.3from
StAlKeR7779:feat/lycoris-support-2.3

Conversation

@StAlKeR7779

@StAlKeR7779 StAlKeR7779 commented Apr 5, 2023

Copy link
Copy Markdown
Contributor

Implementation of LyCORIS(extended LoRA), which is 2 formats - LoCon and LoHa(info1, info2).

It's works but i found 2 a bit different implementations of forward function for LoHa. Both works, but I don't know which is better.

2 functions generate same images if remove self.org_module.weight.data addition from LyCORIS implementation, but who's right?

@StAlKeR7779

Copy link
Copy Markdown
Contributor Author

@lstein @blessedcoolant

@lstein

lstein commented Apr 5, 2023

Copy link
Copy Markdown
Collaborator

Thanks for the PR!

I just tried this out. It seems to work with some lycoris models and not others:

Bias parsing, fix LoHa parsing and weight calculation

@lstein lstein left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing this! The code looks good and tests out on all the LyCORIS LoRAs I tried.

@lstein
lstein merged commit ab9756b into invoke-ai:feat/lora-support-2.3 Apr 6, 2023
@hipsterusername

Copy link
Copy Markdown
Member

@StAlKeR7779 👏

@StAlKeR7779
StAlKeR7779 deleted the feat/lycoris-support-2.3 branch April 6, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants