Prompt Attention Fixes

[joshistoast]

Summary

Addresses issues, oversights and edge cases surrounding the prompt attention hotkey feature.

Fixes and Improvements:

• Add more supported punctuations so they don't get parsed away;
• Fixed floating point corruption, numeric weighting is now more predictable;
• Added attention style preference to settings modal;
• Added prompt functions to AST;
• Now respects prompt functions like .blend(), .and() and .or();
• Now respects mismatched and missing quote pairing in above prompt functions.
• (more fixes will be added here as they come)

Related Issues / Discussions

Discussed in #8736

QA Instructions

Merge Plan

Checklist

• The PR has a short but descriptive title, suitable for a changelog
• Tests added / updated (if applicable)
• ❗Changes to a redux slice have a corresponding migration
• Documentation added / updated (if applicable)
• Updated What's New copy (if doing a release after this PR)

[DustyShoe]

Based on my quick testing, the outermost parentheses wrapping the entire chunked prompt are still being stripped. The same issue occurs with .and()

Example:

("high detail, (cinematic lighting)1.25, soft volumetric light, (sharp focus)+, professional photography",
 "a young woman with balanced natural proportions, medium length brown hair, neutral expression, casual modern clothing",
 "subtle rim light, shallow depth of field, natural skin texture, clean background")
.and()

Becomes

"high detail, (cinematic lighting)1.25, soft volumetric light, (sharp focus)+, professional photography+",
 "a young woman with balanced natural proportions, medium length brown hair, neutral expression, casual modern clothing",
 "subtle rim light, shallow depth of field, natural skin texture, clean background"
.and

[lstein]

I can confirm this behavior.

(one,two).and()

Select "one" and press ctrl-+, and it becomes:
one+,two.and

[lstein]

Still has issues with .add() and similar operators. See comments above.

[joshistoast]

@DustyShoe @lstein Last commit addresses quote craziness (mismatches, other entities, none at all)

[DustyShoe]

Looks like it’s working without major changes to the prompt structure.

However, I have a small nitpick: it still flattens the prompt if it is written in separate paragraphs.

For example:

("chunk 1, with many, words, bla bla, bla bla, bla bla",

 "chunk 2, with many, words, bla bla, bla bla, bla bla",

 "chunk 3, with many, words, bla bla, bla bla, bla bla",

 "chunk 4, with many, words, bla bla, bla bla, bla bla")
.and()

Becomes:

("chunk 1, with many, words, bla bla, bla bla, bla bla", "chunk 2, with many, words, bla bla, bla bla, bla bla", "chunk 3, with many, words, bla bla, bla bla, bla bla", "chunk 4, (with many)+, words, bla bla, bla bla, bla bla").and()
I would prefer that it not modify the structure of the prompt at all. Also it missed the space before .and()

[lstein]

@joshistoast Are you intending to make changes in response to @DustyShoe 's nit? If not, I'm ok going ahead with an approval and merge and you can attend to this detail at a later date.

[joshistoast]

@joshistoast Are you intending to make changes in response to @DustyShoe 's nit? If not, I'm ok going ahead with an approval and merge and you can attend to this detail at a later date.

I can try getting to it this Monday. But I feel like if we keep delaying these important fixes for new bug reports, they'll never get merged in.

[joshistoast]

This should fix it

[lstein]

It is working well in my hands. There may be other weird edge conditions, but I couldn't find them easily.