Skip to content

Fix (UI): Extend input draggability fix to all browsers - #9100

Merged
lstein merged 12 commits into
invoke-ai:mainfrom
ufuksarp:fix-extend-dnd-input-fix
Jul 27, 2026
Merged

lstein merged 12 commits into
invoke-ai:mainfrom
ufuksarp:fix-extend-dnd-input-fix

Conversation

@ufuksarp

Copy link
Copy Markdown
Contributor

Summary

This PR extends the existing input/textarea draggability fix to all browsers, which previously only covered Firefox.

Changes:

  • Removed the Firefox user agent guard so the mouseover/mouseout draggable toggle runs in all browsers.
  • Renamed firefoxDndFix to dndInputFix. All 6 callers updated.
  • Edited relevant comments.
  • Removed the now-unused noop import.

Related Issues / Discussions

None.

QA Instructions

In a Chromium-based browser:

  1. Open the canvas and add a raster layer.
  2. From the layer's context menu, add Adjustments.
  3. In the Adjustments panel, try to click and drag over the value in number input boxes.
  4. Before this PR the layer row starts being dragged for reordering. After this PR the text inside the input gets selected normally.
  5. Confirm dragging the layer row itself still works as expected when the drag starts from a non-input area (header, title, etc).
  6. Also retest in Firefox to confirm no regression of the original fix.

Merge Plan

Standard merge.

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • ❗Changes to a redux slice have a corresponding migration
  • Documentation added / updated (if applicable)
  • Updated What's New copy (if doing a release after this PR)

@github-actions github-actions Bot added the frontend PRs that change frontend files label Apr 30, 2026
@lstein lstein added the 6.14.0 label May 9, 2026
@lstein lstein moved this to 6.14.x Theme: LIBRARY UPDATES in Invoke - Community Roadmap May 9, 2026
@joshistoast

Copy link
Copy Markdown
Collaborator

@ufuksarp You've got a bad import in useRefImageDnD.ts that's bricking the frontend

@ufuksarp

Copy link
Copy Markdown
Contributor Author

@ufuksarp You've got a bad import in useRefImageDnD.ts that's bricking the frontend

Ahh, it seems the older #9081 PR brought a new file. I fixed the import on that which called the function with its old name.
It's a good idea to test the reference panel behaviour as well then.

@joshistoast joshistoast left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, feels good

@lstein
lstein requested a review from JPPhoto as a code owner July 27, 2026 20:35
@lstein
lstein enabled auto-merge (squash) July 27, 2026 20:35
@lstein
lstein merged commit 4347b43 into invoke-ai:main Jul 27, 2026
17 checks passed
@ufuksarp
ufuksarp deleted the fix-extend-dnd-input-fix branch July 28, 2026 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.14.0 frontend PRs that change frontend files

Projects

Status: 6.14.x Theme: USER EXPERIENCE

Development

Successfully merging this pull request may close these issues.

4 participants